Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 8505046: Revert r109283, r109282 and r109239. (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
9 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Revert r109283, r109282 and r109239. "Add callback support for stdout and stderr." "Add tests for both universal_newlines=True and False." "Implement accelerated tee support for POSIX." The reason is that the semantic of subprocess2.check_call(cmd, timeout=60, stderr=subprocess2.STDOUT) changed, stderr wasn't redirected to VOID anymore and for an unknown reason, it was hanging until the timeout happened. Will reapply r109239 with a new regression test to detect that bug. TBR=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -504 lines) Patch
M subprocess2.py View 5 chunks +25 lines, -253 lines 0 comments Download
M tests/subprocess2_test.py View 7 chunks +63 lines, -251 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 1 month ago (2011-11-10 02:17:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8505046/1
9 years, 1 month ago (2011-11-10 02:17:59 UTC) #2
commit-bot: I haz the power
Change committed as 109369
9 years, 1 month ago (2011-11-10 02:23:44 UTC) #3
Dirk Pranke
9 years, 1 month ago (2011-11-10 02:25:17 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698