ntp: make the app promo button use LaunchApp instead of being a dumb <a> link

ntp: make the app promo button use LaunchApp instead of being a dumb <a> link

this is for the purposes of UMA, also for setting the proper referer. For some reason (due to the scheme I take it) links on the NTP have blank referers.

BUG=82857
TEST=manual

[jstritar, 2011-11-10 19:08:40]

I'm not that familiar with this code anymore, but this is updating the web store
entry in the app launcher, not just the web store link in the promo that appears
when you have no apps?

[jstritar, 2011-11-10 19:12:37]

When I test locally, clicking the web store entry already goes through
LaunchApp. The bug is for the actual web store entry, not the promo link, so I
think we can just WONTFIX this if the referrer is being set.

[Evan Stade, 2011-11-10 19:16:17]

when you test locally, does clicking the button displayed as part of the apps
promo go through LaunchApp?

[jstritar, 2011-11-11 21:32:18]

yeah it does

[Evan Stade, 2011-11-12 02:51:35]

On 2011/11/11 21:32:18, jstritar wrote:
> yeah it does

how are you testing this? with both js and C++ breakpoints I can confirm it
doesn't, but the icon does.

[jstritar, 2011-11-14 16:00:36]

I was printing out the ID with a log statement in LaunchApp. We're probably not
referring to the web store link. I was testing the big web store icon that's
located with all the other apps. (The one you can drag and drop around...)

[Evan Stade, 2011-11-14 19:28:16]

On 2011/11/14 16:00:36, jstritar wrote:
> I was printing out the ID with a log statement in LaunchApp. We're probably
not
> referring to the web store link. I was testing the big web store icon that's
> located with all the other apps. (The one you can drag and drop around...)

I am talking about the app promo button. http://www/~estade/no_crawl/button.png

[Evan Stade, 2011-11-17 00:36:16]

ping

[jstritar, 2011-11-17 16:12:08]

We want to route that button through LaunchApp since we control the URL server
side and already embedded tracking code in it. This bug is for the web store
icon that's located with the other apps (I made the same mistake a while ago),
so this should be WONTFIX if LaunchApp already adds the referrer.

[jstritar, 2011-11-17 16:25:25]

er, I mean we *don't* want to send that button through LaunchApp

[Evan Stade, 2011-11-17 23:24:36]

Why is that URL controlled server side? I would like it to always be the same as
the icon, modulo tracking. See http://codereview.chromium.org/8526017/.

[jstritar, 2011-11-18 17:37:58]

That came from from marketing requirements. The entire promo section is defined
server side -- the icon, text, URL, etc -- so that we could promote specific
features.