chrome/browser/browser_about_handler.cc - Issue 8505033: Allow JSONWriter and JSONValueSerializer to omit binary values when instructed to do so.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 8505033: Allow JSONWriter and JSONValueSerializer to omit binary values when instructed to do so. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Joi's comments. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_about_handler.cc

diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc

index 6e4d126f5804adf102631c60d710aa59963bce6f..7aea48a9fc84cf231e4521e03b8890509efd3fef 100644

--- a/chrome/browser/browser_about_handler.cc

+++ b/chrome/browser/browser_about_handler.cc

@@ -1006,7 +1006,8 @@ std::string AboutStats(const std::string& query) {

std::string data;

if (query == "json" || query == kStringsJsPath) {

- base::JSONWriter::WriteWithOptionalEscape(&root, true, false, &data);

+ base::JSONWriter::Write(&root, true,

+ base::JSONWriter::OPTIONS_DO_NOT_ESCAPE, &data);

if (query == kStringsJsPath)

data = "var templateData = " + data + ";";

} else if (query == "raw") {

« base/json/json_writer_unittest.cc ('K') | « base/json/json_writer_unittest.cc ('k') | no next file » | no next file with comments »