Allow JSONWriter and JSONValueSerializer to omit binary values when instructed to do so.

base/json/json_value_serializer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_JSON_JSON_VALUE_SERIALIZER_H_
 #define BASE_JSON_JSON_VALUE_SERIALIZER_H_
 #pragma once
 
 #include <string>
 
@@ skipping 20 matching lines @@
       : json_string_(&const_cast<std::string&>(json_string)),
         initialized_with_const_string_(true),
         pretty_print_(false),
         allow_trailing_comma_(false) {
   }
 
   virtual ~JSONStringValueSerializer();
 
   // Attempt to serialize the data structure represented by Value into
   // JSON.  If the return value is true, the result will have been written
-  // into the string passed into the constructor.
+  // into the string passed into the constructor. In the overloaded method,

[Jói, 2011/11/10 11:08:16]

Please document this separately rather than together.  It might make most sense
to document the first Serialize as "equialent to calling Serialize(root, false)"

[Eric Dingle, 2011/11/10 15:05:25]

Done.

+  // |ignore_binary_values| is used to indicate how the serializer should
+  // behave when encountering a binary value.
   virtual bool Serialize(const Value& root);
+  virtual bool Serialize(const Value& root, bool ignore_binary_values);
 
   // Attempt to deserialize the data structure encoded in the string passed
   // in to the constructor into a structure of Value objects.  If the return
   // value is NULL, and if |error_code| is non-null, |error_code| will
   // contain an integer error code (either JsonFileError or JsonParseError).
   // If |error_message| is non-null, it will be filled in with a formatted
   // error message including the location of the error if appropriate.
   // The caller takes ownership of the returned value.
   virtual Value* Deserialize(int* error_code, std::string* error_message);
 
@@ skipping 27 matching lines @@
 
   // DO NOT USE except in unit tests to verify the file was written properly.
   // We should never serialize directly to a file since this will block the
   // thread. Instead, serialize to a string and write to the file you want on
   // the file thread.
   //
   // Attempt to serialize the data structure represented by Value into
   // JSON.  If the return value is true, the result will have been written
   // into the file whose name was passed into the constructor.
   virtual bool Serialize(const Value& root);
+  virtual bool Serialize(const Value& root, bool ignore_binary_values);
 
   // Attempt to deserialize the data structure encoded in the file passed
   // in to the constructor into a structure of Value objects.  If the return
   // value is NULL, and if |error_code| is non-null, |error_code| will
   // contain an integer error code (either JsonFileError or JsonParseError).
   // If |error_message| is non-null, it will be filled in with a formatted
   // error message including the location of the error if appropriate.
   // The caller takes ownership of the returned value.
   virtual Value* Deserialize(int* error_code, std::string* error_message);
 
@@ skipping 20 matching lines @@
   FilePath json_file_path_;
 
   // A wrapper for file_util::ReadFileToString which returns a non-zero
   // JsonFileError if there were file errors.
   int ReadFileToString(std::string* json_string);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(JSONFileValueSerializer);
 };
 
 #endif  // BASE_JSON_JSON_VALUE_SERIALIZER_H_