Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 8505012: A small collection of cleanup in the parser and AST. (Closed)

Created:
9 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 1 month ago
Reviewers:
Steven, danno
CC:
v8-dev
Visibility:
Public.

Description

A small collection of cleanup in the parser and AST. * Remove a couple of unused fields from the FunctionLiteral, ensure that all the bools are packed. * Rename SaveScope and LexicalScope in the parser. * Use an enum to generate the numbers 0..N and the dependent count, rather than static const ints. This is simpler to extend (coming in a future change). R=danno@chromium.org,keuchel@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -122 lines) Patch
M src/ast.h View 4 chunks +32 lines, -29 lines 0 comments Download
M src/compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.h View 6 chunks +28 lines, -23 lines 0 comments Download
M src/parser.cc View 18 chunks +62 lines, -67 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 1 month ago (2011-11-09 12:26:49 UTC) #1
Steven
9 years, 1 month ago (2011-11-09 13:00:19 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698