Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8505004: TaskManager: Fix to make format of i18n-content values to be of JavaScriptCase (Closed)

Created:
9 years, 1 month ago by NaveenBobbili (Motorola)
Modified:
9 years, 1 month ago
Reviewers:
yoshiki, James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews), yoshiki+watch_chromium.org
Visibility:
Public.

Description

TaskManager: Fix to make format of i18n-content values to be of JavaScriptCase. http://www.chromium.org/developers/web-development-style-guide BUG=103515 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109830

Patch Set 1 #

Patch Set 2 : Fixed merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -47 lines) Patch
M chrome/browser/resources/task_manager/main.html View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/task_manager/main.js View 1 2 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_ui.cc View 1 1 chunk +34 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
NaveenBobbili (Motorola)
Please review.
9 years, 1 month ago (2011-11-09 07:13:40 UTC) #1
James Hawkins
lgtm
9 years, 1 month ago (2011-11-09 16:48:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qghc36@motorola.com/8505004/1
9 years, 1 month ago (2011-11-10 04:38:06 UTC) #3
commit-bot: I haz the power
Try job failure for 8505004-1 (retry) (retry) on win_rel for step "chrome_frame_net_tests". It's a second ...
9 years, 1 month ago (2011-11-10 06:43:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qghc36@motorola.com/8505004/1
9 years, 1 month ago (2011-11-10 06:46:01 UTC) #5
commit-bot: I haz the power
Try job failure for 8505004-1 (retry) (retry) on win_rel for step "chrome_frame_net_tests". It's a second ...
9 years, 1 month ago (2011-11-10 08:37:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qghc36@motorola.com/8505004/1
9 years, 1 month ago (2011-11-10 10:50:49 UTC) #7
commit-bot: I haz the power
Try job failure for 8505004-1 (retry) on win_rel for step "chrome_frame_net_tests". It's a second try, ...
9 years, 1 month ago (2011-11-10 12:07:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qghc36@motorola.com/8505004/1
9 years, 1 month ago (2011-11-11 04:07:06 UTC) #9
commit-bot: I haz the power
Can't apply patch for file chrome/browser/resources/task_manager/main.js. While running patch -p1 --forward --force; patching file chrome/browser/resources/task_manager/main.js ...
9 years, 1 month ago (2011-11-11 04:07:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qghc36@motorola.com/8505004/9001
9 years, 1 month ago (2011-11-13 12:24:54 UTC) #11
commit-bot: I haz the power
9 years, 1 month ago (2011-11-13 13:28:46 UTC) #12 
Change committed as 109830

Powered by Google App Engine
This is Rietveld 408576698