chrome/browser/prerender/prerender_browsertest.cc - Issue 8503040: Prerendering: Add MatchComplete PPLT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 8503040: Prerendering: Add MatchComplete PPLT (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prerender/prerender_browsertest.cc

===================================================================

--- chrome/browser/prerender/prerender_browsertest.cc (revision 109293)

+++ chrome/browser/prerender/prerender_browsertest.cc (working copy)

@@ -127,7 +127,8 @@

should_be_shown_(expected_final_status == FINAL_STATUS_USED),

quit_message_loop_on_destruction_(

expected_final_status != FINAL_STATUS_EVICTED &&

- expected_final_status != FINAL_STATUS_APP_TERMINATING),

+ expected_final_status != FINAL_STATUS_APP_TERMINATING &&

+ expected_final_status != FINAL_STATUS_MATCH_COMPLETE_DUMMY),

expected_pending_prerenders_(0) {

if (expected_number_of_loads == 0)

MessageLoopForUI::current()->Quit();

@@ -303,11 +304,11 @@

const GURL& referrer,

Origin origin,

uint8 experiment_id) OVERRIDE {

- CHECK(!expected_final_status_queue_.empty()) <<

- "Creating prerender contents for " << url.path() <<

- " with no expected final status";

- FinalStatus expected_final_status = expected_final_status_queue_.front();

- expected_final_status_queue_.pop_front();

+ FinalStatus expected_final_status = FINAL_STATUS_MATCH_COMPLETE_DUMMY;

+ if (!expected_final_status_queue_.empty()) {

+ expected_final_status = expected_final_status_queue_.front();

+ expected_final_status_queue_.pop_front();

+ }

VLOG(1) << "Creating prerender contents for " << url.path() <<

" with expected final status " << expected_final_status;

VLOG(1) << expected_final_status_queue_.size() << " left in the queue.";