Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2681)

Unified Diff: chrome/browser/notifications/balloon_collection_gtk.cc

Issue 8503037: Fix the problem that notifications and panels overlap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix per feedback Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/balloon_collection_gtk.cc
diff --git a/chrome/browser/notifications/balloon_collection_gtk.cc b/chrome/browser/notifications/balloon_collection_gtk.cc
index 2420735f72016bcb90b005615545ae8ed5203de6..5b8a7848b2cf8504faf9e74e2a3f08ac02adef7a 100644
--- a/chrome/browser/notifications/balloon_collection_gtk.cc
+++ b/chrome/browser/notifications/balloon_collection_gtk.cc
@@ -35,6 +35,14 @@ int BalloonCollectionImpl::Layout::VerticalEdgeMargin() const {
return 5;
}
+bool BalloonCollectionImpl::Layout::NeedToMoveAboveLeftSidePanels() const {
+ return placement_ == VERTICALLY_FROM_BOTTOM_LEFT;
+}
+
+bool BalloonCollectionImpl::Layout::NeedToMoveAboveRightSidePanels() const {
+ return placement_ == VERTICALLY_FROM_BOTTOM_RIGHT;
+}
+
void BalloonCollectionImpl::PositionBalloons(bool reposition) {
PositionBalloonsInternal(reposition);
}
@@ -92,6 +100,7 @@ void BalloonCollectionImpl::SetPositionPreference(
else
NOTREACHED();
+ layout_.ComputeOffsetToMoveAbovePanels(gfx::Rect());
PositionBalloons(true);
}

Powered by Google App Engine
This is Rietveld 408576698