Fix the problem that notifications and panels overlap.

chrome/browser/ui/panels/base_panel_browser_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/base_panel_browser_test.h"
 
 #include "chrome/browser/ui/browser_list.h"
 
 #include "base/command_line.h"
 #include "base/message_loop.h"
@@ skipping 156 matching lines @@
 
 void BasePanelBrowserTest::SetUpOnMainThread() {
   InProcessBrowserTest::SetUpOnMainThread();
 
   // Setup the work area and desktop bar so that we have consistent testing
   // environment for all panel related tests.
   PanelManager* panel_manager = PanelManager::GetInstance();
   mock_auto_hiding_desktop_bar_ = new MockAutoHidingDesktopBarImpl(
       panel_manager);
   panel_manager->set_auto_hiding_desktop_bar(mock_auto_hiding_desktop_bar_);
-  panel_manager->SetWorkAreaForTesting(testing_work_area_);
+  // The subclass might override testing_work_area_ to make it empty so that
+  // we will not provide our own testing work area. This is used in testing
+  // the interaction with desktop notification which does not have testing
+  // working area hook up.
+  if (!testing_work_area_.IsEmpty())

[jennb, 2011/11/09 21:44:34]

This comment makes me worry that tests are affecting each other. How about
getting rid of set_testing_work_area() and have the subclass override
testing_work_area() instead? Then change line 182 to
panel_manager->SetWorkAreaForTestign(testing_work_area());

+    panel_manager->SetWorkAreaForTesting(testing_work_area_);
   panel_manager->enable_auto_sizing(false);
   panel_manager->remove_delays_for_testing();
   // This is needed so the subsequently created panels can be activated.
   // On a Mac, it transforms background-only test process into foreground one.
   EXPECT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
 }
 
 void BasePanelBrowserTest::WaitForPanelActiveState(
     Panel* panel, ActiveState expected_state) {
   DCHECK(expected_state == SHOW_AS_ACTIVE ||
@@ skipping 137 matching lines @@
   std::string error;
   scoped_refptr<Extension> extension = Extension::Create(
       full_path,  location, *input_value,
       Extension::STRICT_ERROR_CHECKS, &error);
   EXPECT_TRUE(extension.get());
   EXPECT_STREQ("", error.c_str());
   browser()->GetProfile()->GetExtensionService()->
       OnExtensionInstalled(extension.get(), false, -1);
   return extension;
 }