Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3637)

Unified Diff: chrome/browser/ui/webui/active_downloads_ui.cc

Issue 8503018: Split DownloadItem into an ABC, an Impl, and a Mock. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: merge Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/active_downloads_ui.cc
diff --git a/chrome/browser/ui/webui/active_downloads_ui.cc b/chrome/browser/ui/webui/active_downloads_ui.cc
index eb804b5f6b95ce2ebadf04593ab2a1e1ec3d95c3..c24ff9464d8959cf28b32af740a9fae1e99c7e11 100644
--- a/chrome/browser/ui/webui/active_downloads_ui.cc
+++ b/chrome/browser/ui/webui/active_downloads_ui.cc
@@ -300,8 +300,8 @@ void ActiveDownloadsHandler::UpdateDownloadList() {
void ActiveDownloadsHandler::AddDownload(DownloadItem* item) {
// Observe in progress and dangerous downloads.
- if (item->state() == DownloadItem::IN_PROGRESS ||
- item->safety_state() == DownloadItem::DANGEROUS) {
+ if (item->GetState() == DownloadItem::IN_PROGRESS ||
+ item->GetSafetyState() == DownloadItem::DANGEROUS) {
active_downloads_.push_back(item);
DownloadList::const_iterator it =
@@ -327,11 +327,11 @@ void ActiveDownloadsHandler::OnDownloadUpdated(DownloadItem* item) {
find(downloads_.begin(), downloads_.end(), item);
if (it == downloads_.end()) {
- NOTREACHED() << "Updated item " << item->full_path().value()
+ NOTREACHED() << "Updated item " << item->GetFullPath().value()
<< " not found";
}
- if (item->state() == DownloadItem::REMOVING || item->auto_opened()) {
+ if (item->GetState() == DownloadItem::REMOVING || item->GetAutoOpened()) {
// Item is going away, or item is an extension that has auto opened.
item->RemoveObserver(this);
downloads_.erase(it);

Powered by Google App Engine
This is Rietveld 408576698