Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6207)

Unified Diff: chrome/browser/ui/gtk/download/download_shelf_gtk.cc

Issue 8503018: Split DownloadItem into an ABC, an Impl, and a Mock. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: merge Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/download/download_shelf_gtk.cc
diff --git a/chrome/browser/ui/gtk/download/download_shelf_gtk.cc b/chrome/browser/ui/gtk/download/download_shelf_gtk.cc
index 68e5cfa85c092d1abd3a1104759dcf8bc81cf169..cc6901a794fa41c8a5d0d0848e1430a906def11b 100644
--- a/chrome/browser/ui/gtk/download/download_shelf_gtk.cc
+++ b/chrome/browser/ui/gtk/download/download_shelf_gtk.cc
@@ -219,12 +219,12 @@ void DownloadShelfGtk::Closed() {
download->IsCancelled() ||
download->IsInterrupted();
if (is_transfer_done &&
- download->safety_state() != DownloadItem::DANGEROUS) {
+ download->GetSafetyState() != DownloadItem::DANGEROUS) {
RemoveDownloadItem(download_items_[i]);
} else {
// We set all remaining items as "opened", so that the shelf will auto-
// close in the future without the user clicking on them.
- download->set_opened(true);
+ download->SetOpened(true);
++i;
}
}
@@ -303,7 +303,7 @@ void DownloadShelfGtk::OnButtonClick(GtkWidget* button) {
void DownloadShelfGtk::AutoCloseIfPossible() {
for (std::vector<DownloadItemGtk*>::iterator iter = download_items_.begin();
iter != download_items_.end(); ++iter) {
- if (!(*iter)->get_download()->opened())
+ if (!(*iter)->get_download()->GetOpened())
return;
}
« no previous file with comments | « chrome/browser/ui/gtk/download/download_item_gtk.cc ('k') | chrome/browser/ui/views/download/download_item_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698