Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4840)

Unified Diff: chrome/browser/download/download_crx_util.cc

Issue 8503018: Split DownloadItem into an ABC, an Impl, and a Mock. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: merge Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/download/download_extension_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_crx_util.cc
diff --git a/chrome/browser/download/download_crx_util.cc b/chrome/browser/download/download_crx_util.cc
index f709f9c07b0c66e81e0a1e04381d6a413b7fdcb7..8fa5bed3134a79428e9c69f50fab18492acd3ff7 100644
--- a/chrome/browser/download/download_crx_util.cc
+++ b/chrome/browser/download/download_crx_util.cc
@@ -61,21 +61,21 @@ scoped_refptr<CrxInstaller> OpenChromeExtension(
installer->set_delete_source(true);
if (UserScript::IsURLUserScript(download_item.GetURL(),
- download_item.mime_type())) {
- installer->InstallUserScript(download_item.full_path(),
+ download_item.GetMimeType())) {
+ installer->InstallUserScript(download_item.GetFullPath(),
download_item.GetURL());
} else {
bool is_gallery_download = service->IsDownloadFromGallery(
- download_item.GetURL(), download_item.referrer_url());
- installer->set_original_mime_type(download_item.original_mime_type());
+ download_item.GetURL(), download_item.GetReferrerUrl());
+ installer->set_original_mime_type(download_item.GetOriginalMimeType());
installer->set_apps_require_extension_mime_type(true);
installer->set_download_url(download_item.GetURL());
installer->set_is_gallery_install(is_gallery_download);
if (is_gallery_download)
- installer->set_original_download_url(download_item.original_url());
+ installer->set_original_download_url(download_item.GetOriginalUrl());
installer->set_allow_silent_install(is_gallery_download);
installer->set_install_cause(extension_misc::INSTALL_CAUSE_USER_DOWNLOAD);
- installer->InstallCrx(download_item.full_path());
+ installer->InstallCrx(download_item.GetFullPath());
}
return installer;
« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/download/download_extension_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698