Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4250)

Unified Diff: chrome/browser/ui/cocoa/download/download_item_controller.mm

Issue 8503018: Split DownloadItem into an ABC, an Impl, and a Mock. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: CamelCase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/download/download_item_controller.mm
diff --git a/chrome/browser/ui/cocoa/download/download_item_controller.mm b/chrome/browser/ui/cocoa/download/download_item_controller.mm
index eb854ba1fc5d5fad20d349faa1a2229479ed5a7d..8d367b78c59b043f11b9bb5ec3d6f36cc26e1a49 100644
--- a/chrome/browser/ui/cocoa/download/download_item_controller.mm
+++ b/chrome/browser/ui/cocoa/download/download_item_controller.mm
@@ -162,7 +162,7 @@ class DownloadShelfContextMenuMac : public DownloadShelfContextMenu {
DCHECK_EQ(bridge_->download_model(), downloadModel);
// Handle dangerous downloads.
- if (downloadModel->download()->safety_state() == DownloadItem::DANGEROUS) {
+ if (downloadModel->download()->GetSafetyState() == DownloadItem::DANGEROUS) {
[self setState:kDangerous];
ResourceBundle& rb = ResourceBundle::GetSharedInstance();
@@ -195,7 +195,7 @@ class DownloadShelfContextMenuMac : public DownloadShelfContextMenu {
// This basic fixup copies Windows DownloadItemView::DownloadItemView().
// Extract the file extension (if any).
- FilePath filename(downloadModel->download()->target_name());
+ FilePath filename(downloadModel->download()->GetTargetName());
FilePath::StringType extension = filename.Extension();
// Remove leading '.' from the extension
@@ -236,7 +236,7 @@ class DownloadShelfContextMenuMac : public DownloadShelfContextMenu {
// Set correct popup menu. Also, set draggable download on completion.
if (downloadModel->download()->IsComplete()) {
[progressView_ setMenu:completeDownloadMenu_];
- [progressView_ setDownload:downloadModel->download()->full_path()];
+ [progressView_ setDownload:downloadModel->download()->GetFullPath()];
} else {
[progressView_ setMenu:activeDownloadMenu_];
}

Powered by Google App Engine
This is Rietveld 408576698