Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1690)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/download/download_manager_unittest.cc

Issue 8503018: Split DownloadItem into an ABC, an Impl, and a Mock. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: CamelCase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/download/download_item_unittest.cc ('K') | « chrome/browser/download/download_item_unittest.cc ('k') | chrome/browser/download/download_shelf_context_menu.cc » ('j') | content/browser/download/download_item.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_manager_unittest.cc
diff --git a/chrome/browser/download/download_manager_unittest.cc b/chrome/browser/download/download_manager_unittest.cc
index a85fb3efebcc5a9b6295b7ca1953985fb39b3d10..e067d4d7f1889b115952bd9601863f9494b40051 100644
--- a/chrome/browser/download/download_manager_unittest.cc
+++ b/chrome/browser/download/download_manager_unittest.cc
@@ -151,7 +151,7 @@ class DownloadManagerTest : public testing::Test {
bool is_dangerous_url,
int id) {
DownloadItem::SafetyState safety_state =
- download_manager_->GetDownloadItem(id)->safety_state();
+ download_manager_->GetDownloadItem(id)->GetSafetyState();
return (is_dangerous_file || is_dangerous_url) ?
safety_state != DownloadItem::SAFE : safety_state == DownloadItem::SAFE;
}
@@ -357,12 +357,12 @@ class ItemObserver : public DownloadItem::Observer {
// DownloadItem::Observer methods
virtual void OnDownloadUpdated(DownloadItem* download) {
DCHECK_EQ(tracked_, download);
- states_hit_ |= (1 << download->state());
+ states_hit_ |= (1 << download->GetState());
was_updated_ = true;
}
virtual void OnDownloadOpened(DownloadItem* download) {
DCHECK_EQ(tracked_, download);
- states_hit_ |= (1 << download->state());
+ states_hit_ |= (1 << download->GetState());
was_opened_ = true;
}
@@ -512,7 +512,7 @@ TEST_F(DownloadManagerTest, DownloadInterruptTest) {
scoped_ptr<DownloadItemModel> download_item_model(
new DownloadItemModel(download));
- EXPECT_EQ(DownloadItem::IN_PROGRESS, download->state());
+ EXPECT_EQ(DownloadItem::IN_PROGRESS, download->GetState());
scoped_ptr<ItemObserver> observer(new ItemObserver(download));
download_file->AppendDataToFile(kTestData, kTestDataLen);
@@ -534,8 +534,8 @@ TEST_F(DownloadManagerTest, DownloadInterruptTest) {
EXPECT_FALSE(observer->hit_state(DownloadItem::REMOVING));
EXPECT_TRUE(observer->was_updated());
EXPECT_FALSE(observer->was_opened());
- EXPECT_FALSE(download->file_externally_removed());
- EXPECT_EQ(DownloadItem::INTERRUPTED, download->state());
+ EXPECT_FALSE(download->GetFileExternallyRemoved());
+ EXPECT_EQ(DownloadItem::INTERRUPTED, download->GetState());
ui::DataUnits amount_units = ui::GetByteDisplayUnits(kTestDataLen);
string16 simple_size =
ui::FormatBytesWithUnits(error_size, amount_units, false);
@@ -555,10 +555,10 @@ TEST_F(DownloadManagerTest, DownloadInterruptTest) {
EXPECT_FALSE(observer->hit_state(DownloadItem::REMOVING));
EXPECT_TRUE(observer->was_updated());
EXPECT_FALSE(observer->was_opened());
- EXPECT_FALSE(download->file_externally_removed());
- EXPECT_EQ(DownloadItem::INTERRUPTED, download->state());
- EXPECT_EQ(download->received_bytes(), error_size);
- EXPECT_EQ(download->total_bytes(), static_cast<int64>(kTestDataLen));
+ EXPECT_FALSE(download->GetFileExternallyRemoved());
+ EXPECT_EQ(DownloadItem::INTERRUPTED, download->GetState());
+ EXPECT_EQ(download->GetReceivedBytes(), error_size);
+ EXPECT_EQ(download->GetTotalBytes(), static_cast<int64>(kTestDataLen));
}
// Test the behavior of DownloadFileManager and DownloadManager in the event
@@ -599,7 +599,7 @@ TEST_F(DownloadManagerTest, DownloadFileErrorTest) {
scoped_ptr<DownloadItemModel> download_item_model(
new DownloadItemModel(download));
- EXPECT_EQ(DownloadItem::IN_PROGRESS, download->state());
+ EXPECT_EQ(DownloadItem::IN_PROGRESS, download->GetState());
scoped_ptr<ItemObserver> observer(new ItemObserver(download));
// Add some data before finalizing the file name.
@@ -626,8 +626,8 @@ TEST_F(DownloadManagerTest, DownloadFileErrorTest) {
EXPECT_FALSE(observer->hit_state(DownloadItem::REMOVING));
EXPECT_TRUE(observer->was_updated());
EXPECT_FALSE(observer->was_opened());
- EXPECT_FALSE(download->file_externally_removed());
- EXPECT_EQ(DownloadItem::INTERRUPTED, download->state());
+ EXPECT_FALSE(download->GetFileExternallyRemoved());
+ EXPECT_EQ(DownloadItem::INTERRUPTED, download->GetState());
// Check the download shelf's information.
size_t error_size = kTestDataLen * 2;
@@ -680,7 +680,7 @@ TEST_F(DownloadManagerTest, DownloadCancelTest) {
scoped_ptr<DownloadItemModel> download_item_model(
new DownloadItemModel(download));
- EXPECT_EQ(DownloadItem::IN_PROGRESS, download->state());
+ EXPECT_EQ(DownloadItem::IN_PROGRESS, download->GetState());
scoped_ptr<ItemObserver> observer(new ItemObserver(download));
ContinueDownloadWithPath(download, new_path);
@@ -700,8 +700,8 @@ TEST_F(DownloadManagerTest, DownloadCancelTest) {
EXPECT_FALSE(observer->hit_state(DownloadItem::REMOVING));
EXPECT_TRUE(observer->was_updated());
EXPECT_FALSE(observer->was_opened());
- EXPECT_FALSE(download->file_externally_removed());
- EXPECT_EQ(DownloadItem::CANCELLED, download->state());
+ EXPECT_FALSE(download->GetFileExternallyRemoved());
+ EXPECT_EQ(DownloadItem::CANCELLED, download->GetState());
EXPECT_EQ(download_item_model->GetStatusText(),
l10n_util::GetStringUTF16(IDS_DOWNLOAD_STATUS_CANCELED));
@@ -752,7 +752,7 @@ TEST_F(DownloadManagerTest, DownloadOverwriteTest) {
scoped_ptr<DownloadItemModel> download_item_model(
new DownloadItemModel(download));
- EXPECT_EQ(DownloadItem::IN_PROGRESS, download->state());
+ EXPECT_EQ(DownloadItem::IN_PROGRESS, download->GetState());
scoped_ptr<ItemObserver> observer(new ItemObserver(download));
// Create and initialize the download file. We're bypassing the first part
@@ -787,8 +787,8 @@ TEST_F(DownloadManagerTest, DownloadOverwriteTest) {
EXPECT_FALSE(observer->hit_state(DownloadItem::REMOVING));
EXPECT_TRUE(observer->was_updated());
EXPECT_FALSE(observer->was_opened());
- EXPECT_FALSE(download->file_externally_removed());
- EXPECT_EQ(DownloadItem::COMPLETE, download->state());
+ EXPECT_FALSE(download->GetFileExternallyRemoved());
+ EXPECT_EQ(DownloadItem::COMPLETE, download->GetState());
EXPECT_EQ(download_item_model->GetStatusText(), ASCIIToUTF16(""));
EXPECT_TRUE(file_util::PathExists(new_path));
@@ -829,7 +829,7 @@ TEST_F(DownloadManagerTest, DownloadRemoveTest) {
scoped_ptr<DownloadItemModel> download_item_model(
new DownloadItemModel(download));
- EXPECT_EQ(DownloadItem::IN_PROGRESS, download->state());
+ EXPECT_EQ(DownloadItem::IN_PROGRESS, download->GetState());
scoped_ptr<ItemObserver> observer(new ItemObserver(download));
// Create and initialize the download file. We're bypassing the first part
@@ -864,8 +864,8 @@ TEST_F(DownloadManagerTest, DownloadRemoveTest) {
EXPECT_FALSE(observer->hit_state(DownloadItem::REMOVING));
EXPECT_TRUE(observer->was_updated());
EXPECT_FALSE(observer->was_opened());
- EXPECT_FALSE(download->file_externally_removed());
- EXPECT_EQ(DownloadItem::COMPLETE, download->state());
+ EXPECT_FALSE(download->GetFileExternallyRemoved());
+ EXPECT_EQ(DownloadItem::COMPLETE, download->GetState());
EXPECT_EQ(download_item_model->GetStatusText(), ASCIIToUTF16(""));
EXPECT_TRUE(file_util::PathExists(new_path));
@@ -884,8 +884,8 @@ TEST_F(DownloadManagerTest, DownloadRemoveTest) {
EXPECT_FALSE(observer->hit_state(DownloadItem::REMOVING));
EXPECT_TRUE(observer->was_updated());
EXPECT_FALSE(observer->was_opened());
- EXPECT_TRUE(download->file_externally_removed());
- EXPECT_EQ(DownloadItem::COMPLETE, download->state());
+ EXPECT_TRUE(download->GetFileExternallyRemoved());
+ EXPECT_EQ(DownloadItem::COMPLETE, download->GetState());
EXPECT_EQ(download_item_model->GetStatusText(),
l10n_util::GetStringUTF16(IDS_DOWNLOAD_STATUS_REMOVED));
« chrome/browser/download/download_item_unittest.cc ('K') | « chrome/browser/download/download_item_unittest.cc ('k') | chrome/browser/download/download_shelf_context_menu.cc » ('j') | content/browser/download/download_item.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698