Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/automation/automation_provider.cc

Issue 8503018: Split DownloadItem into an ABC, an Impl, and a Mock. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: CamelCase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/automation_provider.cc
diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc
index ba762bd37c2a8522e80ef888353a3d5a0db0f8c9..e9fa606bb1463786bf6c599a79ba835d227517b1 100644
--- a/chrome/browser/automation/automation_provider.cc
+++ b/chrome/browser/automation/automation_provider.cc
@@ -270,21 +270,21 @@ DictionaryValue* AutomationProvider::GetDictionaryFromDownloadItem(
std::string("DANGEROUS_BUT_VALIDATED");
DictionaryValue* dl_item_value = new DictionaryValue;
- dl_item_value->SetInteger("id", static_cast<int>(download->id()));
+ dl_item_value->SetInteger("id", static_cast<int>(download->GetId()));
dl_item_value->SetString("url", download->GetURL().spec());
- dl_item_value->SetString("referrer_url", download->referrer_url().spec());
+ dl_item_value->SetString("referrer_url", download->GetReferrerUrl().spec());
dl_item_value->SetString("file_name",
download->GetFileNameToReportUser().value());
dl_item_value->SetString("full_path",
download->GetTargetFilePath().value());
- dl_item_value->SetBoolean("is_paused", download->is_paused());
+ dl_item_value->SetBoolean("is_paused", download->IsPaused());
dl_item_value->SetBoolean("open_when_complete",
- download->open_when_complete());
- dl_item_value->SetBoolean("is_temporary", download->is_temporary());
- dl_item_value->SetBoolean("is_otr", download->is_otr()); // incognito
- dl_item_value->SetString("state", state_to_string[download->state()]);
+ download->GetOpenWhenComplete());
+ dl_item_value->SetBoolean("is_temporary", download->IsTemporary());
+ dl_item_value->SetBoolean("is_otr", download->IsOtr()); // incognito
+ dl_item_value->SetString("state", state_to_string[download->GetState()]);
dl_item_value->SetString("safety_state",
- safety_state_to_string[download->safety_state()]);
+ safety_state_to_string[download->GetSafetyState()]);
dl_item_value->SetInteger("PercentComplete", download->PercentComplete());
return dl_item_value;

Powered by Google App Engine
This is Rietveld 408576698