Split DownloadItem into an ABC, an Impl, and a Mock.

chrome/browser/ui/cocoa/download/download_item_controller.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/download/download_item_controller.h"
 
 #include "base/mac/mac_util.h"
 #include "base/metrics/histogram.h"
 #include "base/string16.h"
 #include "base/string_util.h"
@@ skipping 145 matching lines @@
   [buttonTweaker_ setFrameOrigin:frameOrigin];
 
   bridge_->LoadIcon();
   [self updateToolTip];
 }
 
 - (void)setStateFromDownload:(BaseDownloadItemModel*)downloadModel {
   DCHECK_EQ(bridge_->download_model(), downloadModel);
 
   // Handle dangerous downloads.
-  if (downloadModel->download()->safety_state() == DownloadItem::DANGEROUS) {
+  if (downloadModel->download()->GetSafetyState() == DownloadItem::DANGEROUS) {
     [self setState:kDangerous];
 
     ResourceBundle& rb = ResourceBundle::GetSharedInstance();
     NSString* dangerousWarning;
     NSString* confirmButtonTitle;
     NSImage* alertIcon;
 
     // The dangerous download label, button text and icon are different under
     // different cases.
     if (downloadModel->download()->GetDangerType() ==
@@ skipping 12 matching lines @@
       if (ChromeDownloadManagerDelegate::IsExtensionDownload(
               downloadModel->download())) {
         dangerousWarning = l10n_util::GetNSStringWithFixup(
             IDS_PROMPT_DANGEROUS_DOWNLOAD_EXTENSION);
         confirmButtonTitle = l10n_util::GetNSStringWithFixup(
             IDS_CONTINUE_EXTENSION_DOWNLOAD);
       } else {
         // This basic fixup copies Windows DownloadItemView::DownloadItemView().
 
         // Extract the file extension (if any).
-        FilePath filename(downloadModel->download()->target_name());
+        FilePath filename(downloadModel->download()->GetTargetName());
         FilePath::StringType extension = filename.Extension();
 
         // Remove leading '.' from the extension
         if (extension.length() > 0)
           extension = extension.substr(1);
 
         // Elide giant extensions.
         if (extension.length() > kFileNameMaxLength / 2) {
           string16 utf16_extension;
           ui::ElideString(UTF8ToUTF16(extension), kFileNameMaxLength / 2,
@@ skipping 20 matching lines @@
     DCHECK(dangerousWarning);
     [dangerousDownloadLabel_ setStringValue:dangerousWarning];
     DCHECK(confirmButtonTitle);
     [dangerousDownloadConfirmButton_ setTitle:confirmButtonTitle];
     return;
   }
 
   // Set correct popup menu. Also, set draggable download on completion.
   if (downloadModel->download()->IsComplete()) {
     [progressView_ setMenu:completeDownloadMenu_];
-    [progressView_ setDownload:downloadModel->download()->full_path()];
+    [progressView_ setDownload:downloadModel->download()->GetFullPath()];
   } else {
     [progressView_ setMenu:activeDownloadMenu_];
   }
 
   [cell_ setStateFromDownload:downloadModel];
 }
 
 - (void)setIcon:(NSImage*)icon {
   [cell_ setImage:icon];
 }
@@ skipping 162 matching lines @@
     [sender setTitle:l10n_util::GetNSStringWithFixup(
         IDS_DOWNLOAD_MENU_PAUSE_ITEM)];
   } else {
     [sender setTitle:l10n_util::GetNSStringWithFixup(
         IDS_DOWNLOAD_MENU_RESUME_ITEM)];
   }
   menuBridge_->ExecuteCommand(DownloadShelfContextMenuMac::TOGGLE_PAUSE);
 }
 
 @end