Split DownloadItem into an ABC, an Impl, and a Mock.

chrome/browser/download/download_extension_api.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_extension_api.h"
 
 #include <algorithm>
 #include <cctype>
 #include <iterator>
 #include <set>
@@ skipping 434 matching lines @@
   return false;
 }
 
 void DownloadsDragFunction::RunInternal() {
   NOTIMPLEMENTED();
 }
 
 namespace {
 base::DictionaryValue* DownloadItemToJSON(DownloadItem* item) {
   base::DictionaryValue* json = new base::DictionaryValue();
-  json->SetInteger(kIdKey, item->id());
-  json->SetString(kUrlKey, item->original_url().spec());
-  json->SetString(kFilenameKey, item->full_path().LossyDisplayName());
+  json->SetInteger(kIdKey, item->GetId());
+  json->SetString(kUrlKey, item->GetOriginalUrl().spec());
+  json->SetString(kFilenameKey, item->GetFullPath().LossyDisplayName());
   json->SetString(kDangerKey, DangerString(item->GetDangerType()));
   json->SetBoolean(kDangerAcceptedKey,
-      item->safety_state() == DownloadItem::DANGEROUS_BUT_VALIDATED);
-  json->SetString(kStateKey, StateString(item->state()));
-  json->SetBoolean(kPausedKey, item->is_paused());
-  json->SetString(kMimeKey, item->mime_type());
+      item->GetSafetyState() == DownloadItem::DANGEROUS_BUT_VALIDATED);
+  json->SetString(kStateKey, StateString(item->GetState()));
+  json->SetBoolean(kPausedKey, item->IsPaused());
+  json->SetString(kMimeKey, item->GetMimeType());
   json->SetInteger(kStartTimeKey,
-      (item->start_time() - base::Time::UnixEpoch()).InMilliseconds());
-  json->SetInteger(kBytesReceivedKey, item->received_bytes());
-  json->SetInteger(kTotalBytesKey, item->total_bytes());
-  if (item->state() == DownloadItem::INTERRUPTED)
-    json->SetInteger(kErrorKey, static_cast<int>(item->last_reason()));
+      (item->GetStartTime() - base::Time::UnixEpoch()).InMilliseconds());
+  json->SetInteger(kBytesReceivedKey, item->GetReceivedBytes());
+  json->SetInteger(kTotalBytesKey, item->GetTotalBytes());
+  if (item->GetState() == DownloadItem::INTERRUPTED)
+    json->SetInteger(kErrorKey, static_cast<int>(item->GetLastReason()));
   // TODO(benjhayden): Implement endTime and fileSize.
   // json->SetInteger(kEndTimeKey, -1);
-  json->SetInteger(kFileSizeKey, item->total_bytes());
+  json->SetInteger(kFileSizeKey, item->GetTotalBytes());
   return json;
 }
 }  // anonymous namespace
 
 ExtensionDownloadsEventRouter::ExtensionDownloadsEventRouter(
     Profile* profile)
   : profile_(profile),
     manager_(
         profile ?
         DownloadServiceFactory::GetForProfile(profile)->GetDownloadManager() :
@@ skipping 14 matching lines @@
   if (manager_ == NULL)
     return;
   DownloadManager::DownloadVector current_vec;
   manager_->SearchDownloads(string16(), &current_vec);
   DownloadIdSet current_set;
   ItemMap current_map;
   for (DownloadManager::DownloadVector::const_iterator iter =
        current_vec.begin();
        iter != current_vec.end(); ++iter) {
     DownloadItem* item = *iter;
-    int item_id = item->id();
+    int item_id = item->GetId();
     // TODO(benjhayden): Remove the following line when every item's id >= 0,
     // which will allow firing onErased events for items from the history.
     if (item_id < 0) continue;
     DCHECK(current_map.find(item_id) == current_map.end());
     current_set.insert(item_id);
     current_map[item_id] = item;
   }
   DownloadIdSet new_set;  // current_set - downloads_;
   DownloadIdSet erased_set;  // downloads_ - current_set;
   std::insert_iterator<DownloadIdSet> new_insertor(new_set, new_set.begin());
@@ skipping 28 matching lines @@
   ListValue args;
   args.Append(arg);
   std::string json_args;
   base::JSONWriter::Write(&args, false, &json_args);
   profile_->GetExtensionEventRouter()->DispatchEventToRenderers(
       event_name,
       json_args,
       profile_,
       GURL());
 }