Split DownloadItem into an ABC, an Impl, and a Mock.

chrome/browser/ui/views/download/download_item_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/download/download_item_view.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 192 matching lines @@
   } else {
     // Drop down button is glued to the right of the download shelf.
     drop_down_x_left_ =
         size.width() - normal_drop_down_image_set_.top->width();
     drop_down_x_right_ = size.width();
   }
 
   body_hover_animation_.reset(new ui::SlideAnimation(this));
   drop_hover_animation_.reset(new ui::SlideAnimation(this));
 
-  if (download->safety_state() == DownloadItem::DANGEROUS) {
+  if (download->GetSafetyState() == DownloadItem::DANGEROUS) {
     tooltip_text_.clear();
     body_state_ = DANGEROUS;
     drop_down_state_ = DANGEROUS;
     save_button_ = new views::NativeTextButton(this,
         l10n_util::GetStringUTF16(
             ChromeDownloadManagerDelegate::IsExtensionDownload(download) ?
                 IDS_CONTINUE_EXTENSION_DOWNLOAD : IDS_CONFIRM_DOWNLOAD));
     save_button_->set_ignore_minimum_size(true);
     discard_button_ = new views::NativeTextButton(
         this, l10n_util::GetStringUTF16(IDS_DISCARD_DOWNLOAD));
     discard_button_->set_ignore_minimum_size(true);
     AddChildView(save_button_);
     AddChildView(discard_button_);
 
     // Ensure the file name is not too long.
 
     // Extract the file extension (if any).
-    FilePath filename(download->target_name());
+    FilePath filename(download->GetTargetName());
 #if defined(OS_POSIX)
     string16 extension = WideToUTF16(base::SysNativeMBToWide(
         filename.Extension()));
 #else
     string16 extension = filename.Extension();
 #endif
 
     // Remove leading '.'
     if (extension.length() > 0)
       extension = extension.substr(1);
@@ skipping 87 matching lines @@
 }
 
 // DownloadObserver interface.
 
 // Update the progress graphic on the icon and our text status label
 // to reflect our current bytes downloaded, time remaining.
 void DownloadItemView::OnDownloadUpdated(DownloadItem* download) {
   DCHECK(download == download_);
 
   if (body_state_ == DANGEROUS &&
-      download->safety_state() == DownloadItem::DANGEROUS_BUT_VALIDATED) {
+      download->GetSafetyState() == DownloadItem::DANGEROUS_BUT_VALIDATED) {
     // We have been approved.
     ClearDangerousMode();
   }
 
   string16 status_text = model_->GetStatusText();
-  switch (download_->state()) {
+  switch (download_->GetState()) {
     case DownloadItem::IN_PROGRESS:
-      download_->is_paused() ? StopDownloadProgress() : StartDownloadProgress();
+      download_->IsPaused() ? StopDownloadProgress() : StartDownloadProgress();
       LoadIconIfItemPathChanged();
       break;
     case DownloadItem::INTERRUPTED:
       StopDownloadProgress();
       complete_animation_.reset(new ui::SlideAnimation(this));
       complete_animation_->SetSlideDuration(kInterruptedAnimationDurationMs);
       complete_animation_->SetTweenType(ui::Tween::LINEAR);
       complete_animation_->Show();
       SchedulePaint();
       LoadIcon();
       break;
     case DownloadItem::COMPLETE:
-      if (download_->auto_opened()) {
+      if (download_->GetAutoOpened()) {
         parent_->RemoveDownloadView(this);  // This will delete us!
         return;
       }
       StopDownloadProgress();
       complete_animation_.reset(new ui::SlideAnimation(this));
       complete_animation_->SetSlideDuration(kCompleteAnimationDurationMs);
       complete_animation_->SetTweenType(ui::Tween::LINEAR);
       complete_animation_->Show();
       SchedulePaint();
       LoadIcon();
@@ skipping 255 matching lines @@
   if (context_menu_->download_item()) {
     drop_down_pressed_ = false;
     // Showing the menu blocks. Here we revert the state.
     SetState(NORMAL, NORMAL);
   }
 }
 
 void DownloadItemView::GetAccessibleState(ui::AccessibleViewState* state) {
   state->name = accessible_name_;
   state->role = ui::AccessibilityTypes::ROLE_PUSHBUTTON;
-  if (download_->safety_state() == DownloadItem::DANGEROUS) {
+  if (download_->GetSafetyState() == DownloadItem::DANGEROUS) {
     state->state = ui::AccessibilityTypes::STATE_UNAVAILABLE;
   } else {
     state->state = ui::AccessibilityTypes::STATE_HASPOPUP;
   }
 }
 
 void DownloadItemView::ButtonPressed(
     views::Button* sender, const views::Event& event) {
   if (sender == discard_button_) {
     UMA_HISTOGRAM_LONG_TIMES("clickjacking.discard_download",
@@ skipping 312 matching lines @@
 void DownloadItemView::SetState(State body_state, State drop_down_state) {
   if (body_state_ == body_state && drop_down_state_ == drop_down_state)
     return;
 
   body_state_ = body_state;
   drop_down_state_ = drop_down_state;
   SchedulePaint();
 }
 
 void DownloadItemView::ClearDangerousMode() {
-  DCHECK(download_->safety_state() == DownloadItem::DANGEROUS_BUT_VALIDATED &&
+  DCHECK(download_->GetSafetyState() == DownloadItem::DANGEROUS_BUT_VALIDATED &&
          body_state_ == DANGEROUS && drop_down_state_ == DANGEROUS);
 
   body_state_ = NORMAL;
   drop_down_state_ = NORMAL;
 
   // Remove the views used by the dangerous mode.
   RemoveChildView(save_button_);
   delete save_button_;
   save_button_ = NULL;
   RemoveChildView(discard_button_);
@@ skipping 111 matching lines @@
 }
 
 bool DownloadItemView::InDropDownButtonXCoordinateRange(int x) {
   if (x > drop_down_x_left_ && x < drop_down_x_right_)
     return true;
   return false;
 }
 
 void DownloadItemView::UpdateAccessibleName() {
   string16 new_name;
-  if (download_->safety_state() == DownloadItem::DANGEROUS) {
+  if (download_->GetSafetyState() == DownloadItem::DANGEROUS) {
     new_name = dangerous_download_label_->GetText();
   } else {
     new_name = status_text_ + char16(' ') +
         download_->GetFileNameToReportUser().LossyDisplayName();
   }
 
   // If the name has changed, notify assistive technology that the name
   // has changed so they can announce it immediately.
   if (new_name != accessible_name_) {
     accessible_name_ = new_name;
     if (GetWidget()) {
       GetWidget()->NotifyAccessibilityEvent(
           this, ui::AccessibilityTypes::EVENT_NAME_CHANGED, true);
     }
   }
 }