content/browser/debugger/devtools_manager.cc - Issue 8503007: DevTools: reattach to crashed inspected page when it reloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/debugger/devtools_manager.cc

Issue 8503007: DevTools: reattach to crashed inspected page when it reloads (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/debugger/devtools_manager.cc

diff --git a/content/browser/debugger/devtools_manager.cc b/content/browser/debugger/devtools_manager.cc

index 95bf06d3e9d611770a71558975ccaacd724aacd6..7db5ae73ea10eb309224a0607edb51fb5fb96197 100644

--- a/content/browser/debugger/devtools_manager.cc

+++ b/content/browser/debugger/devtools_manager.cc

@@ -146,7 +146,8 @@ void DevToolsManager::UnregisterDevToolsClientHostFor(

void DevToolsManager::OnNavigatingToPendingEntry(RenderViewHost* rvh,

RenderViewHost* dest_rvh,

const GURL& gurl) {

- if (rvh == dest_rvh)

+ if (rvh == dest_rvh && rvh->render_view_termination_status() ==

+ base::TERMINATION_STATUS_STILL_RUNNING)

return;

int cookie = DetachClientHost(rvh);

if (cookie != -1) {

« no previous file with comments | « chrome/browser/debugger/devtools_sanity_unittest.cc ('k') | no next file » | no next file with comments »