Sync Promo: Fix up focus.

chrome/browser/resources/sync_promo.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(sail): Refactor options_page and remove this include.
 <include src="options/options_page.js"/>
 <include src="sync_setup_overlay.js"/>
 
 cr.define('sync_promo', function() {
   /**
@@ skipping 126 matching lines @@
       $('confirm-everything-cancel').addEventListener('click', cancelFunc);
       $('choose-datatypes-cancel').addEventListener('click', cancelFunc);
 
       this.infographic_ = $('promo-infographic');
       this.learnMore_ = $('promo-information');
 
       this.infographic_.addEventListener('webkitTransitionEnd',
                                          this.toggleHidden_.bind(this));
       this.learnMore_.addEventListener('webkitTransitionEnd',
                                        this.toggleHidden_.bind(this));
+
+      // Start the page focused on the email/username field.
+      $('gaia-email').focus();

[sail, 2011/11/09 01:54:39]

I don't think this is the correct fix.

sync_setup_handler.js:showGaiaLogin_: already attempts to put focus on the
correct field.

The correct fix would be to fix that so that it works for the promo.

+
+      // Fix tab order for only the sync promo by breaking the byte order and
+      // putting the learn more button on top via [tabindex].
+      $('promo-learn-more-show').tabIndex = 1;
+      $('promo-learn-more-hide').tabIndex = 1;
     },
 
     /**
      * Remove the [hidden] attribute from the node that was not previously
      * transitioning.
      * @param {Event} e A -webkit-transition end event.
      * @private
      */
     toggleHidden_: function(e) {
       // Only show the other element if the target of this event was hidden
@@ skipping 74 matching lines @@
 
   // Export
   return {
     SyncPromo : SyncPromo
   };
 });
 
 var OptionsPage = options.OptionsPage;
 var SyncSetupOverlay = sync_promo.SyncPromo;
 window.addEventListener('DOMContentLoaded', sync_promo.SyncPromo.initialize);