Add Windows desktop shortcut for multiple profiles.

chrome/browser/profiles/profile_manager.cc

Index: chrome/browser/profiles/profile_manager.cc
===================================================================
--- chrome/browser/profiles/profile_manager.cc	(revision 109887)
+++ chrome/browser/profiles/profile_manager.cc	(working copy)
@@ -213,6 +213,9 @@
 
 ProfileManager::~ProfileManager() {
   BrowserList::RemoveObserver(this);
+#if defined(OS_WIN)
+  profile_info_cache_->RemoveObserver(profile_shortcut_manager_.get());

[Robert Sesek, 2011/11/18 14:13:43]

The ShortcutManager could add and remove itself as an observer in its ctor and
dtor.

[grt (UTC plus 2), 2011/11/18 16:02:15]

If you go that route, be sure to either explicitly insert
profile_shortcut_manager_.reset() here to force its destruction, or document in
the .h that the profile_shortcut_manager_ member MUST come after the
profile_info_cache_ member so that its dtor runs first.

[Miranda Callahan, 2011/11/18 19:00:36]

Hmm -- I didn't do this because both the PIC and the PSM_win are held as
scoped_ptrs in the ProfileManager. If I manage the deletion in the PSM_win dtor,
then I have to be sure the ordering of these two instance vars is correct within
the ProfileManager header file, or the PSM_win may try to remove itself from an
already-destructed PIC. Keeping the add/delete in the PM means that I'm assured
that both objects are alive and well when I detach one from the other.

[Miranda Callahan, 2011/11/18 19:00:36]

Yup -- this came in after I had written the above comment. :-) I think it's wise
to avoid trickery in destruction order, if possible...

+#endif
 }
 
 FilePath ProfileManager::GetDefaultProfileDir(
@@ -590,6 +593,10 @@
   if (!profile_info_cache_.get()) {
     profile_info_cache_.reset(new ProfileInfoCache(
         g_browser_process->local_state(), user_data_dir_));
+#if defined(OS_WIN)
+    profile_shortcut_manager_.reset(new ProfileShortcutManagerWin());
+    profile_info_cache_->AddObserver(profile_shortcut_manager_.get());
+#endif
   }
   return *profile_info_cache_.get();
 }