Add Windows desktop shortcut for multiple profiles.

chrome/browser/profiles/profile_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class keeps track of the currently-active profiles in the runtime.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 #pragma once
 
 #include <list>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/hash_tables.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/threading/non_thread_safe.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_init.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 
+#if defined(OS_WIN)
+#include "chrome/browser/profiles/profile_shortcut_manager_win.h"
+#endif
+
 class NewProfileLauncher;
 class ProfileInfoCache;
 
 class ProfileManagerObserver {
  public:
   enum Status {
-    // So epic.
+    // Asynchronous Profile services were not created.
     STATUS_FAIL,
     // Profile created but before initializing extensions and promo resources.
     STATUS_CREATED,
     // Profile is created, extensions and promo resources are initialized.
     STATUS_INITIALIZED
   };
 
   // This method is called when profile is ready. If profile already exists,
   // method is called with pointer to that profile and STATUS_INITIALIZED.
   // If profile creation has failed, method is called with |profile| equal to
@@ skipping 139 matching lines @@
   static bool IsMultipleProfilesEnabled();
 
   // Autoloads profiles if they are running background apps.
   void AutoloadProfiles();
 
   // Register and add testing profile to the ProfileManager. Use ONLY in tests.
   // This allows the creation of Profiles outside of the standard creation path
   // for testing. If |addToCache|, add to ProfileInfoCache as well.
   void RegisterTestingProfile(Profile* profile, bool addToCache);
 
+#if defined(OS_WIN)
+  // Remove the shortcut manager for testing.
+  void RemoveProfileShortcutManagerForTesting();
+#endif
+
   const FilePath& user_data_dir() const { return user_data_dir_; }
 
  protected:
   // Does final initial actions.
   virtual void DoFinalInit(Profile* profile, bool go_off_the_record);
   virtual void DoFinalInitForServices(Profile* profile, bool go_off_the_record);
   virtual void DoFinalInitLogging(Profile* profile);
 
   // Creates a new profile. Virtual so that unittests can return TestingProfile.
   virtual Profile* CreateProfile(const FilePath& path);
@@ skipping 33 matching lines @@
   ProfileInfo* RegisterProfile(Profile* profile, bool created);
 
   typedef std::pair<FilePath, string16> ProfilePathAndName;
   typedef std::vector<ProfilePathAndName> ProfilePathAndNames;
   ProfilePathAndNames GetSortedProfilesFromDirectoryMap();
 
   static bool CompareProfilePathAndName(
       const ProfileManager::ProfilePathAndName& pair1,
       const ProfileManager::ProfilePathAndName& pair2);
 
-  // Adds |profile| to the profile info cache if it's not already there.
+  // Adds |profile| to the profile info cache if it hasn't been added yet.
   void AddProfileToCache(Profile* profile);
 
   // For ChromeOS, determines if profile should be otr.
   bool ShouldGoOffTheRecord();
 
   // Get the path of the next profile directory and increment the internal
   // count.
   // Lack of side effects:
   // This function doesn't actually create the directory or touch the file
   // system.
   FilePath GenerateNextProfileDirectoryPath();
 
   content::NotificationRegistrar registrar_;
 
   // The path to the user data directory (DIR_USER_DATA).
   const FilePath user_data_dir_;
 
   // Indicates that a user has logged in and that the profile specified
   // in the --login-profile command line argument should be used as the
   // default.
   bool logged_in_;
 
   // True if an import process will be run.
   bool will_import_;
 
   // Maps profile path to ProfileInfo (if profile has been created). Use
-  // RegisterProfile() to add into this map.
+  // RegisterProfile() to add into this map. This map owns all loaded profile
+  // objects in a running instance of Chrome.
   typedef std::map<FilePath, linked_ptr<ProfileInfo> > ProfilesInfoMap;
   ProfilesInfoMap profiles_info_;
 
-  // Object to cache various information about profiles.
+  // Object to cache various information about profiles. Contains information
+  // about every profile which has been created for this instance of Chrome,

[Robert Sesek, 2011/11/21 16:00:37]

über-nit: s/which/that

[Miranda Callahan, 2011/11/21 18:19:52]

From The Chicago Manual of Style Online
(http://www.chicagomanualofstyle.org/CMS_FAQ/Whichvs.That/Whichvs.That01.html):

"Some people use “which” restrictively, which is more or less okay (and popular
among writers of British English) as long as no commas are involved:
Pianos which have a fourth pedal to mute the strings are popular among apartment
owners."

[Robert Sesek, 2011/11/21 18:29:33]

I _guess_ I can let it slide, if you really want to be one of those "some
people"…

+  // if it has not been explicitly deleted.
   scoped_ptr<ProfileInfoCache> profile_info_cache_;
 
+#if defined(OS_WIN)
+  // Manages the creation, deletion, and renaming of Windows shortcuts by
+  // observing the ProfileInfoCache.
+  scoped_ptr<ProfileShortcutManagerWin> profile_shortcut_manager_;
+#endif
+
   DISALLOW_COPY_AND_ASSIGN(ProfileManager);
 };
 
 // Same as the ProfileManager, but doesn't initialize some services of the
 // profile. This one is useful in unittests.
 class ProfileManagerWithoutInit : public ProfileManager {
  public:
   explicit ProfileManagerWithoutInit(const FilePath& user_data_dir);
 
  protected:
   virtual void DoFinalInitForServices(Profile*, bool) OVERRIDE {}
   virtual void DoFinalInitLogging(Profile*) OVERRIDE {}
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_