Refactor ProfileManager::DoFinalInit(...) to allow for a more flexible ProfileManagerWithoutInit....

chrome/browser/profiles/profile_manager.h

Index: chrome/browser/profiles/profile_manager.h
===================================================================
--- chrome/browser/profiles/profile_manager.h	(revision 109036)
+++ chrome/browser/profiles/profile_manager.h	(working copy)
@@ -195,6 +195,8 @@
  protected:
   // Does final initial actions.
   virtual void DoFinalInit(Profile* profile, bool go_off_the_record);
+  virtual void DoFinalServicesInit(Profile* profile, bool go_off_the_record);
+  virtual void DoFinalInitLogging(Profile* profile);
 
   // Creates a new profile. Virtual so that unittests can return TestingProfile.
   virtual Profile* CreateProfile(const FilePath& path);
@@ -285,7 +287,8 @@
   explicit ProfileManagerWithoutInit(const FilePath& user_data_dir);
 
  protected:
-  virtual void DoFinalInit(Profile*, bool) {}
+  virtual void DoFinalServicesInit(Profile*, bool) {}

[Robert Sesek, 2011/11/09 19:07:46]

OVERRIDE on both of these

+  virtual void DoFinalInitLogging(Profile*) {}

[Robert Sesek, 2011/11/09 19:07:46]

I'd standardize the naming here. Either DoFinalInit(For)Services or
DoFinalServicesInit. I prefer the former.

 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_