Refactor ProfileManager::DoFinalInit(...) to allow for a more flexible ProfileManagerWithoutInit....

Refactor ProfileManager::DoFinalInit(...) to allow for a more flexible ProfileManagerWithoutInit. Factored out the parts of DoFinalInit that are not desired in ProfileManagerWithoutInit and for ProfileManager unit tests. This is to make it possible to write unit tests for code that belongs in DoFinalInit, such as setting up the ProfileInfoCache entry for a profile.

BUG=NONE
TEST=unit_tests --gtest_filter=ProfileManager*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109647

[Robert Sesek, 2011-11-09 19:07:46]

Also, I think the TEST= line is "unit_tests --gtest_filter=ProfileManager*"

http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_manager.cc (right):

http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager.cc:470: 
nit: remove

http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_manager.h (right):

http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager.h:290: virtual void
DoFinalServicesInit(Profile*, bool) {}
OVERRIDE on both of these

http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager.h:291: virtual void
DoFinalInitLogging(Profile*) {}
I'd standardize the naming here. Either DoFinalInit(For)Services or
DoFinalServicesInit. I prefer the former.

[jwd, 2011-11-09 20:57:22]

Made the changes.

On 2011/11/09 19:07:46, rsesek wrote:
> Also, I think the TEST= line is "unit_tests --gtest_filter=ProfileManager*"
> 
>
http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
> File chrome/browser/profiles/profile_manager.cc (right):
> 
>
http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
> chrome/browser/profiles/profile_manager.cc:470: 
> nit: remove
> 
>
http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
> File chrome/browser/profiles/profile_manager.h (right):
> 
>
http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
> chrome/browser/profiles/profile_manager.h:290: virtual void
> DoFinalServicesInit(Profile*, bool) {}
> OVERRIDE on both of these
> 
>
http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
> chrome/browser/profiles/profile_manager.h:291: virtual void
> DoFinalInitLogging(Profile*) {}
> I'd standardize the naming here. Either DoFinalInit(For)Services or
> DoFinalServicesInit. I prefer the former.

[jwd, 2011-11-09 20:59:35]

Oops, forgot the TEST field change. Made that now
On 2011/11/09 20:57:22, Jesse Doherty wrote:
> Made the changes.
> 
> On 2011/11/09 19:07:46, rsesek wrote:
> > Also, I think the TEST= line is "unit_tests --gtest_filter=ProfileManager*"
> > 
> >
>
http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
> > File chrome/browser/profiles/profile_manager.cc (right):
> > 
> >
>
http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
> > chrome/browser/profiles/profile_manager.cc:470: 
> > nit: remove
> > 
> >
>
http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
> > File chrome/browser/profiles/profile_manager.h (right):
> > 
> >
>
http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
> > chrome/browser/profiles/profile_manager.h:290: virtual void
> > DoFinalServicesInit(Profile*, bool) {}
> > OVERRIDE on both of these
> > 
> >
>
http://codereview.chromium.org/8502031/diff/4001/chrome/browser/profiles/prof...
> > chrome/browser/profiles/profile_manager.h:291: virtual void
> > DoFinalInitLogging(Profile*) {}
> > I'd standardize the naming here. Either DoFinalInit(For)Services or
> > DoFinalServicesInit. I prefer the former.

[Robert Sesek, 2011-11-10 15:55:20]

lgtm

[commit-bot: I haz the power, 2011-11-10 15:59:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jwd@chromium.org/8502031/9001

[commit-bot: I haz the power, 2011-11-10 15:59:56]

Presubmit check for 8502031-9001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/profiles/profile_manager.cc,chrome/browser/profiles/profile_manager.h

Presubmit checks took 2.8s to calculate.

[sail, 2011-11-10 23:02:56]

lgtm

[commit-bot: I haz the power, 2011-11-11 16:19:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jwd@chromium.org/8502031/9001

[commit-bot: I haz the power, 2011-11-11 17:26:31]

Change committed as 109647