Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1646)

Unified Diff: net/spdy/spdy_proxy_client_socket.cc

Issue 8502024: Allow chrome to handle 407 auth challenges to CONNECT requests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: fix typo in unittest Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_proxy_client_socket.h ('k') | net/spdy/spdy_proxy_client_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_proxy_client_socket.cc
===================================================================
--- net/spdy/spdy_proxy_client_socket.cc (revision 110584)
+++ net/spdy/spdy_proxy_client_socket.cc (working copy)
@@ -63,6 +63,19 @@
return response_.headers ? &response_ : NULL;
}
+int SpdyProxyClientSocket::RestartWithAuth(OldCompletionCallback* callback) {
+ // A SPDY Stream can only handle a single request, so the underlying
+ // stream may not be reused and a new SpdyProxyClientSocket must be
+ // created (possibly on top of the same SPDY Session).
+ next_state_ = STATE_DISCONNECTED;
+ return OK;
+}
+
+const
+scoped_refptr<HttpAuthController>& SpdyProxyClientSocket::auth_controller() {
+ return auth_;
+}
+
HttpStream* SpdyProxyClientSocket::CreateConnectResponseStream() {
DCHECK(response_stream_.get());
return response_stream_.release();
@@ -384,6 +397,16 @@
if (response_.headers->response_code() == 200) {
return OK;
} else if (response_.headers->response_code() == 407) {
+ int rv = HandleAuthChallenge(auth_, &response_, net_log_);
+ if (rv != ERR_PROXY_AUTH_REQUESTED) {
+ return rv;
+ }
+ // SPDY only supports basic and digest auth
+ if (auth_->auth_info() &&
+ (auth_->auth_info()->scheme == "basic" ||
+ auth_->auth_info()->scheme == "digest")) {
+ return ERR_PROXY_AUTH_REQUESTED;
+ }
return ERR_TUNNEL_CONNECTION_FAILED;
} else {
// Immediately hand off our SpdyStream to a newly created SpdyHttpStream
« no previous file with comments | « net/spdy/spdy_proxy_client_socket.h ('k') | net/spdy/spdy_proxy_client_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698