Issue 8502019: Added internal Protector key to official build

Issue 8502019: Added internal Protector key to official build (Closed)

Created:
9 years, 1 month ago by whywhat

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, Paweł Hajdan Jr., dhollowa, Ivan Korotkov, Dmitry Polukhin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Added internal Protector key to official build Increase WebData version, rewrite DSP backup signature. R=sky@chromium.org BUG=94447 TEST=Verify that Web Data version is 41, Default Search Provider ID Backup Signature is not empty in any build, different for official build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109038

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added check for DSP #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -7 lines)			Patch
M	chrome/browser/webdata/keyword_table.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/webdata/keyword_table.cc	View		1 chunk	+12 lines, -1 line	0 comments	Download
M	chrome/browser/webdata/web_database.cc	View		2 chunks	+11 lines, -3 lines	0 comments	Download
M	chrome/browser/webdata/web_database_migration_unittest.cc	View	1	3 chunks	+80 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+11 lines, -0 lines	0 comments	Download
A	chrome/test/data/web_database/version_40.sql	View		1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/8502019/diff/1/chrome/browser/webdata/web_database_migration_unittest.cc File chrome/browser/webdata/web_database_migration_unittest.cc (right): http://codereview.chromium.org/8502019/diff/1/chrome/browser/webdata/web_database_migration_unittest.cc#newcode1647 chrome/browser/webdata/web_database_migration_unittest.cc:1647: EXPECT_EQ(default_search_provider_id, default_search_provider_id_backup); Can you add a EXPECT_NE(0, default_search_provider_id).

9 years, 1 month ago (2011-11-08 15:55:44 UTC) #3

whywhat

9 years, 1 month ago (2011-11-08 16:20:18 UTC) #4

http://codereview.chromium.org/8502019/diff/1/chrome/browser/webdata/web_data...
File chrome/browser/webdata/web_database_migration_unittest.cc (right):

http://codereview.chromium.org/8502019/diff/1/chrome/browser/webdata/web_data...
chrome/browser/webdata/web_database_migration_unittest.cc:1647:
EXPECT_EQ(default_search_provider_id, default_search_provider_id_backup);
On 2011/11/08 15:55:44, sky wrote:
> Can you add a EXPECT_NE(0, default_search_provider_id).

Done.

Expand Messages | Collapse Messages