Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 8502012: Improve dominator computation to avoid worst-case quadratic time. (Closed)

Created:
9 years, 1 month ago by fschneider
Modified:
9 years, 1 month ago
Reviewers:
floitsch
CC:
v8-dev
Visibility:
Public.

Description

Improve dominator computation to avoid worst-case quadratic time. In case of a degenerated CFG like in the example below processing predecessors in the wrong order yields n^2 runtime. do { if (x) break; if (x) break; if (x) break; if (x) break; if (x) break; if (x) break; if (x) break; if (x) break; if (x) break; if (x) break; if (x) break; // etc. } while (false); Reversing iteration order avoids this. Committed: http://code.google.com/p/v8/source/detail?r=9905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
floitsch
9 years, 1 month ago (2011-11-08 09:26:23 UTC) #1
LGTM.

Powered by Google App Engine
This is Rietveld 408576698