Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: tests/standalone/src/TestRunnerTest.dart

Issue 8502008: Fix the TestRunnerTest. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/TestRunnerTest.dart
diff --git a/tests/standalone/src/TestRunnerTest.dart b/tests/standalone/src/TestRunnerTest.dart
index fb4a42607d04d4c7ec891b5c50b5ad8608e5da20..ed8f90b24ff6681915d0bc1ed46c340862c19083 100644
--- a/tests/standalone/src/TestRunnerTest.dart
+++ b/tests/standalone/src/TestRunnerTest.dart
@@ -44,10 +44,10 @@ TestCase MakeTestCase(String testName, List<String> expectations) {
test_path = "../tests/standalone/src/${testName}.dart";
}
- return new TestCase(getDartShellFileName(), <String>[
- "--ignore-unrecognized-flags",
- "--enable_type_checks",
- "tests/standalone/src/${testName}.dart"],
+ return new TestCase(getDartShellFileName(),
+ <String>["--ignore-unrecognized-flags",
+ "--enable_type_checks",
+ test_path],
TestController.processCompletedTest,
new Set<String>.from(expectations));
}
@@ -68,18 +68,19 @@ String getProcessTestFileName() {
}
void main() {
- new RunningProcess(MakeTestCase("PassTest", [PASS]), 10).start();
- new RunningProcess(MakeTestCase("FailTest", [FAIL]), 10).start();
- new RunningProcess(MakeTestCase("TimeoutTest", [TIMEOUT]), 10).start();
+ int timeout = 1;
Bill Hesse 2011/11/08 09:48:06 Isn't 1 second a bit extreme? We won't get flaky
+ new RunningProcess(MakeTestCase("PassTest", [PASS]), timeout).start();
+ new RunningProcess(MakeTestCase("FailTest", [FAIL]), timeout).start();
+ new RunningProcess(MakeTestCase("TimeoutTest", [TIMEOUT]), timeout).start();
new RunningProcess(new TestCase(getProcessTestFileName(),
const ["0", "0", "1", "1"],
TestController.processCompletedTest,
new Set<String>.from([CRASH])),
- 10).start();
+ timeout).start();
Expect.equals(4, TestController.numTests);
// Throw must be from body of start() function for this test to work.
Expect.throws(
- new RunningProcess(MakeTestCase("PassTest", [SKIP]), 10).start);
+ new RunningProcess(MakeTestCase("PassTest", [SKIP]), timeout).start);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698