tests/callingconv_case_by_case/for_each_type.h - Issue 8502006: Extend callingconv_case_by_case test to exercise the "pnaclcall"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/callingconv_case_by_case/for_each_type.h

Issue 8502006: Extend callingconv_case_by_case test to exercise the "pnaclcall" (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: comment Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/callingconv_case_by_case/for_each_type.h

diff --git a/tests/callingconv_case_by_case/for_each_type.h b/tests/callingconv_case_by_case/for_each_type.h

index e7fd1504897396725a35f469db123f5e0509409c..e606ac32e2cd06a220dae81e3aeb0a7475b31725 100644

--- a/tests/callingconv_case_by_case/for_each_type.h

+++ b/tests/callingconv_case_by_case/for_each_type.h

@@ -61,17 +61,8 @@ DO_FOR_TYPE(CLASS_I32_I32)

DO_FOR_TYPE(CLASS_DOUBLE_DOUBLE)

DO_FOR_TYPE(U_CLASS_INT_CLASS)

-/* These are currently borked for callsites on 32-bit and 64-bit PNaCl

- * calling into 32-bit and 64-bit NNaCl, even with the compatibility

- * flag "-mstructs-on-stack". See:

- * http://code.google.com/p/nativeclient/issues/detail?id=2403

- *

- * Returning is fine, since that doesn't involve a superfluous "byval".

- */

- /* (should be fixed when we do a pull down of the latest clang)

DO_FOR_TYPE(NONTRIV_CLASS_I32_I32)

DO_FOR_TYPE(NONTRIV_CLASS_DOUBLE_DOUBLE)

-*/

DO_FOR_TYPE(MEMBER_PTRS)

DO_FOR_TYPE(MEMBER_FUN_PTRS)

« no previous file with comments | « tests/callingconv_case_by_case/call_structs.cc ('k') | tests/callingconv_case_by_case/nacl.scons » ('j') | no next file with comments »