Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2265)

Unified Diff: base/tracked_objects_unittest.cc

Issue 8502001: Switch to using an intergral type for durations inside profiler (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/tracked_objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/tracked_objects_unittest.cc
===================================================================
--- base/tracked_objects_unittest.cc (revision 109652)
+++ base/tracked_objects_unittest.cc (working copy)
@@ -118,27 +118,25 @@
scoped_ptr<DeathData> data(new DeathData());
ASSERT_NE(data, reinterpret_cast<DeathData*>(NULL));
- EXPECT_EQ(data->run_duration(), Duration());
- EXPECT_EQ(data->queue_duration(), Duration());
+ EXPECT_EQ(data->run_duration(), 0);
+ EXPECT_EQ(data->queue_duration(), 0);
EXPECT_EQ(data->AverageMsRunDuration(), 0);
EXPECT_EQ(data->AverageMsQueueDuration(), 0);
EXPECT_EQ(data->count(), 0);
- int run_ms = 42;
- int queue_ms = 8;
+ DurationInt run_ms = 42;
+ DurationInt queue_ms = 8;
- Duration run_duration = Duration().FromMilliseconds(run_ms);
- Duration queue_duration = Duration().FromMilliseconds(queue_ms);
- data->RecordDeath(queue_duration, run_duration);
- EXPECT_EQ(data->run_duration(), run_duration);
- EXPECT_EQ(data->queue_duration(), queue_duration);
+ data->RecordDeath(queue_ms, run_ms);
+ EXPECT_EQ(data->run_duration(), run_ms);
+ EXPECT_EQ(data->queue_duration(), queue_ms);
EXPECT_EQ(data->AverageMsRunDuration(), run_ms);
EXPECT_EQ(data->AverageMsQueueDuration(), queue_ms);
EXPECT_EQ(data->count(), 1);
- data->RecordDeath(queue_duration, run_duration);
- EXPECT_EQ(data->run_duration(), run_duration + run_duration);
- EXPECT_EQ(data->queue_duration(), queue_duration + queue_duration);
+ data->RecordDeath(queue_ms, run_ms);
+ EXPECT_EQ(data->run_duration(), run_ms + run_ms);
+ EXPECT_EQ(data->queue_duration(), queue_ms + queue_ms);
EXPECT_EQ(data->AverageMsRunDuration(), run_ms);
EXPECT_EQ(data->AverageMsQueueDuration(), queue_ms);
EXPECT_EQ(data->count(), 2);
« no previous file with comments | « base/tracked_objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698