Switch to using an intergral type for durations inside profiler

base/tracked_objects.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/tracked_objects.h"
 
 #include <math.h>
 
 #include "base/format_macros.h"
 #include "base/message_loop.h"
@@ skipping 15 matching lines @@
 // that we only record after parsing the command line flag --enable-tracking.
 // Note that the flag may force either state, so this really controls only the
 // period of time up until that flag is parsed. If there is no flag seen, then
 // this state may prevail for much or all of the process lifetime.
 static const ThreadData::Status kInitialStartupState = ThreadData::ACTIVE;
 }  // anonymous namespace.
 
 //------------------------------------------------------------------------------
 // DeathData tallies durations when a death takes place.
 
-void DeathData::RecordDeath(const Duration& queue_duration,
-                            const Duration& run_duration) {
+void DeathData::RecordDeath(DurationInt queue_duration,
+                            DurationInt run_duration) {
   ++count_;
   queue_time_.AddDuration(queue_duration);
   run_time_.AddDuration(run_duration);
 }
 
-int DeathData::AverageMsRunDuration() const {
+DurationInt DeathData::AverageMsRunDuration() const {
   return run_time_.AverageMsDuration(count_);
 }
 
-int DeathData::AverageMsQueueDuration() const {
+DurationInt DeathData::AverageMsQueueDuration() const {
   return queue_time_.AverageMsDuration(count_);
 }
 
 void DeathData::AddDeathData(const DeathData& other) {
   count_ += other.count_;
   queue_time_.AddData(other.queue_time_);
   run_time_.AddData(other.run_time_);
 }
 
 void DeathData::WriteHTML(std::string* output) const {
   if (!count_)
     return;
   base::StringAppendF(output, "%s:%d, ",
                       (count_ == 1) ? "Life" : "Lives", count_);
   output->append("Run:");
   run_time_.WriteHTML(count_, output);
 
   output->append("Queue:");
   queue_time_.WriteHTML(count_, output);
 }
 
 base::DictionaryValue* DeathData::ToValue() const {
   base::DictionaryValue* dictionary = new base::DictionaryValue;
   dictionary->Set("count", base::Value::CreateIntegerValue(count_));
   dictionary->Set("run_ms",
-      base::Value::CreateIntegerValue(run_time_.duration().InMilliseconds()));
+      base::Value::CreateIntegerValue(run_time_.duration()));
   dictionary->Set("queue_ms",
-      base::Value::CreateIntegerValue(queue_time_.duration().InMilliseconds()));
+      base::Value::CreateIntegerValue(queue_time_.duration()));
   dictionary->Set("run_ms_max",
-      base::Value::CreateIntegerValue(run_time_.max().InMilliseconds()));
+      base::Value::CreateIntegerValue(run_time_.max()));
   dictionary->Set("queue_ms_max",
-      base::Value::CreateIntegerValue(queue_time_.max().InMilliseconds()));
+      base::Value::CreateIntegerValue(queue_time_.max()));
   return dictionary;
 }
 
 void DeathData::Clear() {
   count_ = 0;
   run_time_.Clear();
   queue_time_.Clear();
 }
 
 //------------------------------------------------------------------------------
 
 void DeathData::Data::WriteHTML(int count, std::string* output) const {
   // Be careful to leave static_casts intact, as the type returned by
   // InMilliseconds() may not always be an int, even if it can generally fit
   // into an int.
   base::StringAppendF(output, "%dms",
-                      static_cast<int>(duration_.InMilliseconds()));
+                      static_cast<int>(duration_));
   if (count == 1) {
     output->append(" ");
     return;
   }
   base::StringAppendF(output, "(%dms/life,max:%dms) ",
-                      AverageMsDuration(count),
-                      static_cast<int>(max_.InMilliseconds()));
+                      static_cast<int>(AverageMsDuration(count)),
+                      static_cast<int>(max_));
 }
 
 void DeathData::Data::AddData(const Data& other) {
   duration_ += other.duration_;
   if (max_ > other.max_)
     return;
   max_ = other.max_;
 }
 
-void DeathData::Data::AddDuration(const Duration& duration) {
+void DeathData::Data::AddDuration(DurationInt duration) {
   duration_ += duration;
   if (max_ > duration)
     return;
   max_ = duration;
 }
 
-int DeathData::Data::AverageMsDuration(int count) const {
-  if (duration_ == Duration() || !count)
+DurationInt DeathData::Data::AverageMsDuration(int count) const {
+  if (duration_ == 0 || !count)
     return 0;
-  return static_cast<int>(duration_.InMilliseconds() + count / 2) / count;
+  return (duration_ + count / 2) / count;
 }
 
 void DeathData::Data::Clear() {
-  duration_ = Duration();
-  max_ = Duration();
+  duration_ = 0;
+  max_ = 0;
 }
 //------------------------------------------------------------------------------
 BirthOnThread::BirthOnThread(const Location& location,
                              const ThreadData& current)
     : location_(location),
       birth_thread_(&current) {}
 
 //------------------------------------------------------------------------------
 Births::Births(const Location& location, const ThreadData& current)
     : BirthOnThread(location, current),
@@ skipping 255 matching lines @@
 
   Births* tracker = new Births(location, *this);
   // Lock since the map may get relocated now, and other threads sometimes
   // snapshot it (but they lock before copying it).
   base::AutoLock lock(lock_);
   birth_map_[location] = tracker;
   return tracker;
 }
 
 void ThreadData::TallyADeath(const Births& birth,
-                             const Duration& queue_duration,
-                             const Duration& run_duration) {
+                             DurationInt queue_duration,
+                             DurationInt run_duration) {
   DeathMap::iterator it = death_map_.find(&birth);
   DeathData* death_data;
   if (it != death_map_.end()) {
     death_data = &it->second;
   } else {
     base::AutoLock lock(lock_);  // Lock since the map may get relocated now.
     death_data = &death_map_[&birth];
   }  // Release lock ASAP.
   death_data->RecordDeath(queue_duration, run_duration);
 }
@@ skipping 37 matching lines @@
   // have for non-delayed tasks, and we consistently call it queueing delay.
   TrackedTime effective_post_time = completed_task.delayed_run_time.is_null()
       ? tracked_objects::TrackedTime(completed_task.time_posted)
       : tracked_objects::TrackedTime(completed_task.delayed_run_time);
 
   // Watch out for a race where status_ is changing, and hence one or both
   // of start_of_run or end_of_run is zero.  IN that case, we didn't bother to
   // get a time value since we "weren't tracking" and we were trying to be
   // efficient by not calling for a genuine time value. For simplicity, we'll
   // use a default zero duration when we can't calculate a true value.
-  Duration queue_duration;
-  Duration run_duration;
+  DurationInt queue_duration = 0;
+  DurationInt run_duration = 0;
   if (!start_of_run.is_null()) {
-    queue_duration = start_of_run - effective_post_time;
+    queue_duration = (start_of_run - effective_post_time).InMilliseconds();
     if (!end_of_run.is_null())
-      run_duration = end_of_run - start_of_run;
+      run_duration = (end_of_run - start_of_run).InMilliseconds();
   }
   current_thread_data->TallyADeath(*birth, queue_duration, run_duration);
 }
 
 // static
 void ThreadData::TallyRunOnWorkerThreadIfTracking(
     const Births* birth,
     const TrackedTime& time_posted,
     const TrackedTime& start_of_run,
     const TrackedTime& end_of_run) {
@@ skipping 12 matching lines @@
   // (since we'll use locks on TallyBirth and TallyDeath).  The good news is
   // that the locks on TallyDeath will be *after* the worker thread has run, and
   // hence nothing will be waiting for the completion (... besides some other
   // thread that might like to run).  Also, the worker threads tasks are
   // generally longer, and hence the cost of the lock may perchance be amortized
   // over the long task's lifetime.
   ThreadData* current_thread_data = Get();
   if (!current_thread_data)
     return;
 
-  Duration queue_duration;
-  Duration run_duration;
+  DurationInt queue_duration = 0;
+  DurationInt run_duration = 0;
   if (!start_of_run.is_null()) {
-    queue_duration = start_of_run - time_posted;
+    queue_duration = (start_of_run - time_posted).InMilliseconds();
     if (!end_of_run.is_null())
-      run_duration = end_of_run - start_of_run;
+      run_duration = (end_of_run - start_of_run).InMilliseconds();
   }
   current_thread_data->TallyADeath(*birth, queue_duration, run_duration);
 }
 
 // static
 void ThreadData::TallyRunInAScopedRegionIfTracking(
     const Births* birth,
     const TrackedTime& start_of_run,
     const TrackedTime& end_of_run) {
   if (!kTrackAllTaskObjects)
     return;  // Not compiled in.
 
   // Even if we have been DEACTIVATED, we will process any pending births so
   // that our data structures (which counted the outstanding births) remain
   // consistent.
   if (!birth)
     return;
 
   ThreadData* current_thread_data = Get();
   if (!current_thread_data)
     return;
 
-  Duration queue_duration = Duration();
-  Duration run_duration = end_of_run - start_of_run;
+  DurationInt queue_duration = 0;
+  DurationInt run_duration = (end_of_run - start_of_run).InMilliseconds();
   current_thread_data->TallyADeath(*birth, queue_duration, run_duration);
 }
 
 
 
 // static
 ThreadData* ThreadData::first() {
   base::AutoLock lock(*list_lock_);
   return all_thread_data_list_head_;
 }
@@ skipping 706 matching lines @@
                         (combined_selectors_ & BIRTH_THREAD) ? "*" :
                           sample.birth().birth_thread()->thread_name().c_str(),
                         (combined_selectors_ & DEATH_THREAD) ? "*" :
                           sample.DeathThreadName().c_str());
   sample.birth().location().Write(!(combined_selectors_ & BIRTH_FILE),
                                   !(combined_selectors_ & BIRTH_FUNCTION),
                                   output);
 }
 
 }  // namespace tracked_objects