Issue 8501036: Convert extensions code using DictionaryValue::key_iterator and

Issue 8501036: Convert extensions code using DictionaryValue::key_iterator and (Closed)

Created:
9 years, 1 month ago by not at google - send to devlin

Modified:
9 years, 1 month ago

Reviewers:
aa

CC:
chromium-reviews, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Convert extensions code using DictionaryValue::key_iterator and GetWithoutPathExpansion to DictionaryValue::Iterator. BUG= TEST=*Extension* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111345

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -27 lines)			Patch
	M	chrome/browser/extensions/extension_prefs.cc	View		1 chunk	+5 lines, -13 lines	0 comments	Download
	M	chrome/browser/extensions/settings/syncable_settings_storage.cc	View	1	3 chunks	+9 lines, -14 lines	0 comments	Download

Total messages: 7 (0 generated)

not at google - send to devlin

Surprisingly few. Using Iterator means not having the unnecessary GetWithoutPathExpansion. But it might also be ...

9 years, 1 month ago (2011-11-09 02:14:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/8501036/8001

9 years, 1 month ago (2011-11-23 05:10:52 UTC) #4

commit-bot: I haz the power

Try job failure for 8501036-8001 (retry) on mac_rel for step "media_unittests". It's a second try, ...

9 years, 1 month ago (2011-11-23 06:52:56 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/8501036/8001

9 years, 1 month ago (2011-11-23 11:05:52 UTC) #6

Change committed as 111345