Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/isolate_test.cc

Issue 8501034: Deal with unhandled exceptions the same way in all Dart api functions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/dart_api_impl_test.cc ('K') | « runtime/vm/isolate.cc ('k') | runtime/vm/object.h » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate_test.cc
===================================================================
--- runtime/vm/isolate_test.cc (revision 1328)
+++ runtime/vm/isolate_test.cc (working copy)
@@ -43,8 +43,8 @@
Dart_NewString("testMain"),
0,
NULL);
- EXPECT_VALID(result);
- EXPECT(Dart_ExceptionOccurred(result));
+ EXPECT(Dart_IsError(result));
+ EXPECT(Dart_IsUnhandledException(result));
Dart_Handle exception_result = Dart_GetException(result);
EXPECT_VALID(exception_result);
}
« runtime/vm/dart_api_impl_test.cc ('K') | « runtime/vm/isolate.cc ('k') | runtime/vm/object.h » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698