Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: runtime/bin/process.cc

Issue 8501034: Deal with unhandled exceptions the same way in all Dart api functions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/process.cc
===================================================================
--- runtime/bin/process.cc (revision 1328)
+++ runtime/bin/process.cc (working copy)
@@ -34,11 +34,11 @@
ASSERT(Dart_IsList(arguments));
intptr_t length = 0;
Dart_Handle result = Dart_ListLength(arguments, &length);
- ASSERT(Dart_IsValid(result));
+ ASSERT(!Dart_IsError(result));
char** string_args = new char*[length];
for (int i = 0; i < length; i++) {
Dart_Handle arg = Dart_ListGetAt(arguments, i);
- ASSERT(Dart_IsValid(arg));
+ ASSERT(!Dart_IsError(arg));
// The Dart code verifies that the arguments implement the String
// interface. However, only builtin Strings are handled by
// GetStringValue.
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/bin/process_script.cc » ('j') | runtime/include/dart_api.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698