Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: runtime/bin/gen_snapshot.cc

Issue 8501034: Deal with unhandled exceptions the same way in all Dart api functions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/file.cc ('k') | runtime/bin/main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/gen_snapshot.cc
===================================================================
--- runtime/bin/gen_snapshot.cc (revision 1469)
+++ runtime/bin/gen_snapshot.cc (working copy)
@@ -102,7 +102,7 @@
if (script_name != NULL) {
// Load the specified script.
Dart_Handle library = LoadSnapshotCreationScript(script_name);
- if (!Dart_IsValid(library)) {
+ if (Dart_IsError(library)) {
const char* err_msg = Dart_GetError(library);
fprintf(stderr, "Errors encountered while loading script: %s\n", err_msg);
Dart_ExitScope();
@@ -127,7 +127,7 @@
intptr_t size = 0;
// First create the snapshot.
result = Dart_CreateSnapshot(&buffer, &size);
- if (!Dart_IsValid(result)) {
+ if (Dart_IsError(result)) {
const char* err_msg = Dart_GetError(result);
fprintf(stderr, "Error while creating snapshot: %s\n", err_msg);
Dart_ExitScope();
« no previous file with comments | « runtime/bin/file.cc ('k') | runtime/bin/main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698