aura: Make the Linux version of IconLoader not require GTK+.

aura: Make the Linux version of IconLoader not require GTK+.

This change makes it use webkit_glue::ImageDecoder instead
of gdk-pixbuf and hides various GTK+ theme-related code
behind TOOLKIT_USES_GTK ifdefs.  Chrome OS is currently
loading its own icons from resources (see r86936 and
http://crosbug.com/129) instead of using IconLoader and
IconManager, so this only removes NOTIMPLEMENTED()s on
non-Chrome-OS Linux Aura builds (along with simplifying the
GTK+ version of the code).

BUG=99494
TEST=manual: download icons are still visible on a gtk+ build

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109527

[DaveMoore, 2011-11-09 19:20:16]

lgtm.

[commit-bot: I haz the power, 2011-11-10 01:36:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/8501030/4001

[commit-bot: I haz the power, 2011-11-10 01:37:05]

Presubmit check for 8501030-4001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
net/base/platform_mime_util_linux.cc,base/mime_util.h,base/mime_util_xdg.cc

Presubmit checks took 1.5s to calculate.

[Daniel Erat, 2011-11-10 01:39:21]

Will, mind approving for the tiny changes in base/ and net/base/?

[willchan no longer on Chromium, 2011-11-10 21:24:13]

lgtm

http://codereview.chromium.org/8501030/diff/4001/base/mime_util_xdg.cc
File base/mime_util_xdg.cc (right):

http://codereview.chromium.org/8501030/diff/4001/base/mime_util_xdg.cc#newcode7
base/mime_util_xdg.cc:7: #if defined(TOOLKIT_USES_GTK)
Unless it needs to be ordered this way, please move the platform specific
#include after all the other ones, a la
http://dev.chromium.org/developers/coding-style#TOC-Platform-defines.

[Daniel Erat, 2011-11-10 21:43:25]

http://codereview.chromium.org/8501030/diff/4001/base/mime_util_xdg.cc
File base/mime_util_xdg.cc (right):

http://codereview.chromium.org/8501030/diff/4001/base/mime_util_xdg.cc#newcode7
base/mime_util_xdg.cc:7: #if defined(TOOLKIT_USES_GTK)
On 2011/11/10 21:24:14, willchan wrote:
> Unless it needs to be ordered this way, please move the platform specific
> #include after all the other ones, a la
> http://dev.chromium.org/developers/coding-style#TOC-Platform-defines.

Done.

[commit-bot: I haz the power, 2011-11-10 21:44:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/8501030/11001

[commit-bot: I haz the power, 2011-11-10 23:01:26]

Change committed as 109527