Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 8501011: Suppress libvpx warning (Closed)

Created:
9 years, 1 month ago by tzik
Modified:
9 years, 1 month ago
Reviewers:
Alpha Left Google
Base URL:
http://git.chromium.org/chromium/deps/libvpx.git@master
Visibility:
Public.

Description

Suppress libvpx warning BUG= TEST=

Patch Set 1 #

Total comments: 12

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M libvpx.gyp View 1 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tzik
Hi. Recent libvpx.gyp seems to cause build-time warning like below, on building chrome on linux. ...
9 years, 1 month ago (2011-11-08 15:16:37 UTC) #1
Alpha Left Google
LGTM with small changes. http://codereview.chromium.org/8501011/diff/1/libvpx.gyp File libvpx.gyp (right): http://codereview.chromium.org/8501011/diff/1/libvpx.gyp#newcode170 libvpx.gyp:170: 'destination': '<(shared_generated_dir)/encoder', Please rename this ...
9 years, 1 month ago (2011-11-08 15:19:53 UTC) #2
tzik
Thanks for very fast review. BTW, I don't have permission for this repository. Could you ...
9 years, 1 month ago (2011-11-08 15:34:37 UTC) #3
Alpha Left Google
I've set the commit bit, let's see if this works. You'll also need to submit ...
9 years, 1 month ago (2011-11-08 16:19:11 UTC) #4
tzik
Thanks, but maybe no commit bot is watching us. Could you commit it manually? On ...
9 years, 1 month ago (2011-11-09 13:40:54 UTC) #5
Alpha Left Google
9 years, 1 month ago (2011-11-09 13:45:17 UTC) #6
On 2011/11/09 13:40:54, tzik wrote:
> Thanks, but maybe no commit bot is watching us.
> Could you commit it manually?
> 
> On 2011/11/08 16:19:11, Alpha wrote:
> > I've set the commit bit, let's see if this works.
> > 
> > You'll also need to submit a change to pull in this change through DEPS.

change submitted as 109236.

Powered by Google App Engine
This is Rietveld 408576698