Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4733)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 8501005: Include PPAPI plugin crashes in the plugin crash data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Include PPAPI plugin crash info the plugin crash elements on all platforms. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.h
diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h
index 9c92e1c64a7bfe1e0220974e393a04974176881c..643bcb4dd2fa58f6faf78731df6c83681e4bb7ad 100644
--- a/chrome/browser/metrics/metrics_service.h
+++ b/chrome/browser/metrics/metrics_service.h
@@ -19,6 +19,7 @@
#include "base/process_util.h"
#include "chrome/browser/io_thread.h"
#include "chrome/common/metrics_helpers.h"
+#include "content/common/child_process_info.h"
#include "content/public/common/url_fetcher_delegate.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -305,6 +306,10 @@ class MetricsService : public content::NotificationObserver,
// Sets the value of the specified path in prefs and schedules a save.
void RecordBooleanPrefValue(const char* path, bool value);
+ // Returns true if process of type |type| should be counted as a plugin
+ // process, and false otherwise.
+ static bool IsPluginProcess(ChildProcessInfo::ProcessType type);
+
content::NotificationRegistrar registrar_;
// Indicate whether recording and reporting are currently happening.
@@ -385,9 +390,8 @@ class MetricsService : public content::NotificationObserver,
// exited-cleanly bit in the prefs.
static ShutdownCleanliness clean_shutdown_status_;
- FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, ClientIdGeneratesAllZeroes);
- FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, ClientIdGeneratesCorrectly);
FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, ClientIdCorrectlyFormatted);
+ FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, IsPluginProcess);
DISALLOW_COPY_AND_ASSIGN(MetricsService);
};
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698