Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: chrome/browser/metrics/metrics_service_unittest.cc

Issue 8501005: Include PPAPI plugin crashes in the plugin crash data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use filename for PPAPI plugins with no name. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service_unittest.cc
diff --git a/chrome/browser/metrics/metrics_service_unittest.cc b/chrome/browser/metrics/metrics_service_unittest.cc
index 01263deb89571f8224c0a7829e7a627072247192..be07e23fadb3a8cde4ab038837e5498721fad0a1 100644
--- a/chrome/browser/metrics/metrics_service_unittest.cc
+++ b/chrome/browser/metrics/metrics_service_unittest.cc
@@ -28,3 +28,17 @@ TEST(MetricsServiceTest, ClientIdCorrectlyFormatted) {
}
}
+TEST(MetricsServiceTest, IsPluginProcess) {
+ EXPECT_TRUE(
+ MetricsService::IsPluginProcess(ChildProcessInfo::PLUGIN_PROCESS));
+ EXPECT_FALSE(
+ MetricsService::IsPluginProcess(ChildProcessInfo::GPU_PROCESS));
+#if defined(OS_CHROMEOS)
+ bool ppapi_plugin = true;
+#else
+ bool ppapi_plugin = false;
+#endif
+ EXPECT_EQ(
+ ppapi_plugin,
+ MetricsService::IsPluginProcess(ChildProcessInfo::PPAPI_PLUGIN_PROCESS));
jar (doing other things) 2011/11/08 22:16:31 This ifdef should also go away when you use the lo
petkov 2011/11/09 14:21:07 Done.
+}

Powered by Google App Engine
This is Rietveld 408576698