Issue 8500008: base::Bind() conversion for ComponentUpdaterService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8500008: base::Bind() conversion for ComponentUpdaterService. (Closed)

Created:
9 years, 1 month ago by dcheng

Modified:
9 years, 1 month ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind() conversion for ComponentUpdaterService. BUG=none TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110986

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	chrome/browser/component_updater/component_updater_service.cc	View	1 2	5 chunks	+10 lines, -9 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

9 years, 1 month ago (2011-11-21 18:00:16 UTC) #2

lgtm

http://codereview.chromium.org/8500008/diff/3001/chrome/browser/component_upd...
File chrome/browser/component_updater/component_updater_service.cc (right):

http://codereview.chromium.org/8500008/diff/3001/chrome/browser/component_upd...
chrome/browser/component_updater/component_updater_service.cc:698:
base::Unretained(this),
optional suggestion: add comment near the base:Unretained here that says
something like 

// Why Unretained? See comment at top of file.

http://codereview.chromium.org/8500008/diff/3001/chrome/browser/component_upd...
chrome/browser/component_updater/component_updater_service.cc:719:
base::Bind(&CrxUpdateService::DoneInstalling, base::Unretained(this),
same suggestion here

Expand Messages | Collapse Messages