Library prefix should be an identifier

vm/scanner.cc

Index: vm/scanner.cc
===================================================================
--- vm/scanner.cc	(revision 1714)
+++ vm/scanner.cc	(working copy)
@@ -117,6 +117,19 @@
 }
 
 
+bool Scanner::IsIdent(const String& str) {
+  if (!str.IsOneByteString()) {

[hausner, 2011/11/21 19:53:58]

Is there a guarantee that strings will always be of the smallest type, ie. that
we could not encounter the word "if" in a two-byte string?

[siva, 2011/11/21 21:48:04]

No they are not guaranteed to be always the smallest type and hence the check to
filter those out as invalid.

On 2011/11/21 19:53:58, hausner wrote:

+    return false;
+  }
+  for (int i =  0; i < str.Length(); i++) {
+    if (!IsIdentChar(str.CharAt(i))) {

[hausner, 2011/11/21 19:53:58]

The first character in the string must be checked with IsIdentStartChar(),
otherwise "55" would pass as a valid identifier.

Also, you need to check that the string has at least one character.

[siva, 2011/11/21 21:48:04]

Good catch.

On 2011/11/21 19:53:58, hausner wrote:

+      return false;
+    }
+  }
+  return true;
+}
+
+
 void Scanner::ReadChar() {
   if (lookahead_pos_ < source_length_) {
     if (c0_ == '\n') {