Issue 8499050: Change command line switch for controlling profiling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8499050: Change command line switch for controlling profiling (Closed)

Created:
9 years, 1 month ago by jar (doing other things)

Modified:
9 years, 1 month ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Change command line switch for controlling profiling Change --enable-tracking to --enable-profiling r=rtenneti Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109847

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

lgtm http://codereview.chromium.org/8499050/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/8499050/diff/1/chrome/common/chrome_switches.cc#newcode523 chrome/common/chrome_switches.cc:523: // Enables tracking of tasks in profiler for ...

9 years, 1 month ago (2011-11-14 04:28:55 UTC) #2

jar (doing other things)

9 years, 1 month ago (2011-11-14 05:14:13 UTC) #3

change per comment by rtenneti

http://codereview.chromium.org/8499050/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/8499050/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:523: // Enables tracking of tasks in profiler
for viewing via about:tracking.
On 2011/11/14 04:28:55, ramant wrote:
> > about:tracking
> Should this be about:tracking2 (or about:profiling).

Done.

Expand Messages | Collapse Messages

Issue 8499050: Change command line switch for controlling profiling (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages