UserPolicyCache only becomes ready after policy has been fetched.

chrome/browser/policy/enterprise_metrics_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/scoped_temp_dir.h"
 #include "base/time.h"
@@ skipping 292 matching lines @@
   helper.ProcessRegisterRequest();
   EXPECT_TRUE(helper.VerifyAndClearExpectations());
   EXPECT_TRUE(CheckSamples());
 }
 
 TEST_F(EnterpriseMetricsTest, TokenFetchOK) {
   SetMetricName(kMetricToken);
   DeviceManagementBackendTestHelper helper(loop());
 
   // Test token fetcher.
-  UserPolicyCache cache(temp_dir().AppendASCII("FetchTokenTest"));
+  UserPolicyCache cache(temp_dir().AppendASCII("FetchTokenTest"), false);
   scoped_ptr<CloudPolicyDataStore> data_store;
   data_store.reset(CloudPolicyDataStore::CreateForUserPolicies());
   data_store->SetupForTesting("", "fake_device_id", "fake_user_name",
                               "fake_gaia_token", true);
   PolicyNotifier notifier;
   DeviceTokenFetcher fetcher(&helper.service(), &cache, data_store.get(),
                              &notifier);
 
   MockCloudPolicyDataStoreObserver observer;
   data_store->AddObserver(&observer);
@@ skipping 134 matching lines @@
   ExpectSample(kMetricPolicyFetchRequested);
   ExpectSample(kMetricPolicyFetchResponseReceived);
   helper.ProcessPolicyRequest();
   EXPECT_TRUE(helper.VerifyAndClearExpectations());
   EXPECT_TRUE(CheckSamples());
 }
 
 TEST_F(EnterpriseMetricsTest, PolicyFetchInvalidPolicy) {
   SetMetricName(kMetricPolicy);
 
-  UserPolicyCache cache(temp_dir().AppendASCII("UserPolicyCacheTest"));
+  UserPolicyCache cache(temp_dir().AppendASCII("UserPolicyCacheTest"), false);
   UserPolicyDiskCache::Delegate* cache_as_delegate =
       implicit_cast<UserPolicyDiskCache::Delegate*>(&cache);
 
   em::CachedCloudPolicyResponse response;
   response.mutable_cloud_policy()->set_policy_data("\xff");
   cache_as_delegate->OnDiskCacheLoaded(UserPolicyDiskCache::LOAD_RESULT_SUCCESS,
                                        response);
   ExpectSample(kMetricPolicyFetchInvalidPolicy);
   EXPECT_TRUE(CheckSamples());
 }
 
 TEST_F(EnterpriseMetricsTest, PolicyFetchTimestampInFuture) {
   SetMetricName(kMetricPolicy);
 
-  UserPolicyCache cache(temp_dir().AppendASCII("UserPolicyCacheTest"));
+  UserPolicyCache cache(temp_dir().AppendASCII("UserPolicyCacheTest"), false);
   UserPolicyDiskCache::Delegate* cache_as_delegate =
       implicit_cast<UserPolicyDiskCache::Delegate*>(&cache);
 
   std::string data;
   em::PolicyData policy_data;
   base::TimeDelta timestamp =
       (base::Time::NowFromSystemTime() + base::TimeDelta::FromDays(1000)) -
       base::Time::UnixEpoch();
   policy_data.set_timestamp(timestamp.InMilliseconds());
   policy_data.SerializeToString(&data);
   em::CachedCloudPolicyResponse response;
   response.mutable_cloud_policy()->set_policy_data(data);
   cache_as_delegate->OnDiskCacheLoaded(UserPolicyDiskCache::LOAD_RESULT_SUCCESS,
                                        response);
   ExpectSample(kMetricPolicyFetchTimestampInFuture);
   EXPECT_TRUE(CheckSamples());
 }
 
 TEST_F(EnterpriseMetricsTest, PolicyFetchNotModified) {
   SetMetricName(kMetricPolicy);
 
-  UserPolicyCache cache(temp_dir().AppendASCII("UserPolicyCacheTest"));
+  UserPolicyCache cache(temp_dir().AppendASCII("UserPolicyCacheTest"), false);
   UserPolicyDiskCache::Delegate* cache_as_delegate =
       implicit_cast<UserPolicyDiskCache::Delegate*>(&cache);
 
   std::string data;
   em::PolicyData policy_data;
   policy_data.set_timestamp(0);
   policy_data.SerializeToString(&data);
   em::CachedCloudPolicyResponse response;
   response.mutable_cloud_policy()->set_policy_data(data);
   cache_as_delegate->OnDiskCacheLoaded(UserPolicyDiskCache::LOAD_RESULT_SUCCESS,
                                        response);
   ExpectSample(kMetricPolicyFetchNotModified);
   EXPECT_TRUE(CheckSamples());
 }
 
 TEST_F(EnterpriseMetricsTest, PolicyFetchOK) {
   SetMetricName(kMetricPolicy);
 
-  UserPolicyCache cache(temp_dir().AppendASCII("UserPolicyCacheTest"));
+  UserPolicyCache cache(temp_dir().AppendASCII("UserPolicyCacheTest"), false);
 
   std::string data;
   em::PolicyData policy_data;
   policy_data.set_timestamp(0);
   policy_data.SerializeToString(&data);
   em::CachedCloudPolicyResponse response;
   cache.SetPolicy(response.cloud_policy());
   ExpectSample(kMetricPolicyFetchOK);
   ExpectSample(kMetricPolicyFetchNotModified);
   EXPECT_TRUE(CheckSamples());
   // This also triggers a store. Update the expected samples.
   RunAllPending();
   ExpectSample(kMetricPolicyStoreSucceeded);
   EXPECT_TRUE(CheckSamples());
 }
 
 TEST_F(EnterpriseMetricsTest, PolicyFetchBadResponse) {
   SetMetricName(kMetricPolicy);
 
-  UserPolicyCache cache(temp_dir().AppendASCII("UserPolicyCacheTest"));
+  UserPolicyCache cache(temp_dir().AppendASCII("UserPolicyCacheTest"), false);
   PolicyNotifier notifier;
   scoped_ptr<CloudPolicyDataStore> data_store;
   data_store.reset(CloudPolicyDataStore::CreateForUserPolicies());
   data_store->SetupForTesting("", "fake_device_id", "fake_user_name",
                               "fake_gaia_token", true);
   CloudPolicyController controller(NULL, &cache, NULL, data_store.get(),
                                    &notifier);
   em::DevicePolicyResponse device_policy_response;
   controller.HandlePolicyResponse(device_policy_response);
   ExpectSample(kMetricPolicyFetchBadResponse);
@@ skipping 306 matching lines @@
   helper.CompleteRetrieve(chromeos::SignedSettings::NOT_FOUND);
   helper.SetData("\xff");
   helper.SetPolicy();
   ExpectSample(kMetricPolicyFetchInvalidPolicy);
   EXPECT_TRUE(CheckSamples());
 }
 
 #endif
 
 }  // namespace policy