UserPolicyCache only becomes ready after policy has been fetched.

chrome/browser/policy/device_token_fetcher_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/device_token_fetcher.h"
 
 #include "base/message_loop.h"
 #include "base/scoped_temp_dir.h"
 #include "chrome/browser/policy/cloud_policy_data_store.h"
 #include "chrome/browser/policy/logging_work_scheduler.h"
@@ skipping 18 matching lines @@
 class DeviceTokenFetcherTest : public testing::Test {
  protected:
   DeviceTokenFetcherTest()
       : ui_thread_(BrowserThread::UI, &loop_),
         file_thread_(BrowserThread::FILE, &loop_) {
     EXPECT_TRUE(temp_user_data_dir_.CreateUniqueTempDir());
   }
 
   virtual void SetUp() {
     cache_.reset(new UserPolicyCache(
-        temp_user_data_dir_.path().AppendASCII("DeviceTokenFetcherTest")));
+        temp_user_data_dir_.path().AppendASCII("DeviceTokenFetcherTest"),
+        false  /* wait_for_policy_fetch */));
     EXPECT_CALL(service_, CreateBackend())
         .Times(AnyNumber())
         .WillRepeatedly(MockDeviceManagementServiceProxyBackend(&backend_));
     data_store_.reset(CloudPolicyDataStore::CreateForUserPolicies());
     data_store_->AddObserver(&observer_);
   }
 
   virtual void TearDown() {
     loop_.RunAllPending();
     data_store_->RemoveObserver(&observer_);
   }
 
   void FetchToken(DeviceTokenFetcher* fetcher) {
     data_store_->SetupForTesting("", "fake_device_id", "fake_user_name",
                                  "fake_auth_token", true);
     fetcher->FetchToken();
   }
 
+  void CreateNewWaitingCache() {
+    cache_.reset(new UserPolicyCache(
+        temp_user_data_dir_.path().AppendASCII("DeviceTokenFetcherTest"),
+        true  /* wait_for_policy_fetch */));
+    // Make this cache's disk cache ready, but have it still waiting for a
+    // policy fetch.
+    cache_->Load();
+    loop_.RunAllPending();
+    ASSERT_TRUE(cache_->last_policy_refresh_time().is_null());
+    ASSERT_FALSE(cache_->IsReady());
+  }
+
   MessageLoop loop_;
   MockDeviceManagementBackend backend_;
   MockDeviceManagementService service_;
   scoped_ptr<CloudPolicyCacheBase> cache_;
   scoped_ptr<CloudPolicyDataStore> data_store_;
   MockCloudPolicyDataStoreObserver observer_;
   PolicyNotifier notifier_;
   ScopedTempDir temp_user_data_dir_;
 
  private:
@@ skipping 50 matching lines @@
   DeviceTokenFetcher fetcher(&service_, cache_.get(), data_store_.get(),
                              &notifier_);
   EXPECT_CALL(observer_, OnDeviceTokenChanged()).Times(0);
   FetchToken(&fetcher);
   loop_.RunAllPending();
   Mock::VerifyAndClearExpectations(&observer_);
   EXPECT_EQ("", data_store_->device_token());
   EXPECT_TRUE(cache_->is_unmanaged());
 }
 
+TEST_F(DeviceTokenFetcherTest, DontSetFetchingDone0) {

[Mattias Nissler (ping if slow), 2011/11/11 14:38:50]

more descriptive names.

[Joao da Silva, 2011/11/14 15:59:48]

Done.

+  CreateNewWaitingCache();
+  DeviceTokenFetcher fetcher(&service_, cache_.get(), data_store_.get(),
+                             &notifier_);
+  EXPECT_FALSE(cache_->IsReady());
+}
+
+TEST_F(DeviceTokenFetcherTest, DontSetFetchingDone1) {
+  CreateNewWaitingCache();
+  EXPECT_CALL(backend_, ProcessRegisterRequest(_, _, _, _, _)).WillOnce(
+      MockDeviceManagementBackendSucceedRegister());
+  EXPECT_CALL(observer_, OnDeviceTokenChanged());
+  DeviceTokenFetcher fetcher(&service_, cache_.get(), data_store_.get(),
+                             &notifier_);
+  FetchToken(&fetcher);
+  loop_.RunAllPending();
+  // On successful token fetching the cache isn't set to ready, since the next
+  // step is to fetch policy. Only failures to fetch the token should make
+  // the cache ready.
+  EXPECT_FALSE(cache_->IsReady());
+}
+
+TEST_F(DeviceTokenFetcherTest, SetFetchingDone0) {
+  CreateNewWaitingCache();
+  cache_->SetUnmanaged();
+  DeviceTokenFetcher fetcher(&service_, cache_.get(), data_store_.get(),
+                             &notifier_);
+  EXPECT_TRUE(cache_->IsReady());
+}
+
+TEST_F(DeviceTokenFetcherTest, SetFetchingDone1) {
+  CreateNewWaitingCache();
+  EXPECT_CALL(backend_, ProcessRegisterRequest(_, _, _, _, _)).WillOnce(
+      MockDeviceManagementBackendFailRegister(
+          DeviceManagementBackend::kErrorRequestFailed));
+  DeviceTokenFetcher fetcher(&service_, cache_.get(), data_store_.get(),
+                             &notifier_);
+  FetchToken(&fetcher);
+  loop_.RunAllPending();
+  // This is the opposite case of DontSetFetchingDone1.
+  EXPECT_TRUE(cache_->IsReady());
+}
+
 }  // namespace policy