[Mac] Move event hooks from CrApplication to BrowserCrApplication.

[Mac] Move event hooks from CrApplication to BrowserCrApplication.

Removing dependencies from content/.

BUG=102224
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109749

[Scott Hess - ex-Googler, 2011-11-09 01:05:14]

Gotta go, so hopefully the try job willn't fail.

http://codereview.chromium.org/8498034/diff/1/content/common/chrome_applicati...
File content/common/chrome_application_mac.mm (left):

http://codereview.chromium.org/8498034/diff/1/content/common/chrome_applicati...
content/common/chrome_application_mac.mm:46: - (void)sendEvent:(NSEvent*)event {
This is duplicated WRT the subclass in chrome/.  But this entire class will
hopefully go away once I refactor message pump.  Meanwhile, keeping the scoper
to make sure things stay correct.

[Scott Hess - ex-Googler, 2011-11-09 01:05:51]

On 2011/11/09 01:05:14, shess wrote:
> Gotta go, so hopefully the try job willn't fail.

Or maybe I can wait for lkgr to update...

[Robert Sesek, 2011-11-09 18:16:25]

http://codereview.chromium.org/8498034/diff/1/chrome/browser/chrome_browser_a...
File chrome/browser/chrome_browser_application_mac.h (right):

http://codereview.chromium.org/8498034/diff/1/chrome/browser/chrome_browser_a...
chrome/browser/chrome_browser_application_mac.h:1: // Copyright (c) 2010 The
Chromium Authors. All rights reserved.
nit: copyright

http://codereview.chromium.org/8498034/diff/1/chrome/browser/chrome_browser_a...
chrome/browser/chrome_browser_application_mac.h:19: // Array of objects
implementing the CrApplicationEventHookProtocol
nit: full stop

http://codereview.chromium.org/8498034/diff/1/content/common/chrome_applicati...
File content/common/chrome_application_mac.h (right):

http://codereview.chromium.org/8498034/diff/1/content/common/chrome_applicati...
content/common/chrome_application_mac.h:14: #include
"base/memory/scoped_nsobject.h"
nit: remove

http://codereview.chromium.org/8498034/diff/1/content/common/chrome_applicati...
content/common/chrome_application_mac.h:15: #import
"content/common/mac/scoped_sending_event.h"
can move into .mm

[Scott Hess - ex-Googler, 2011-11-09 18:36:53]

http://codereview.chromium.org/8498034/diff/1/chrome/browser/chrome_browser_a...
File chrome/browser/chrome_browser_application_mac.h (right):

http://codereview.chromium.org/8498034/diff/1/chrome/browser/chrome_browser_a...
chrome/browser/chrome_browser_application_mac.h:1: // Copyright (c) 2010 The
Chromium Authors. All rights reserved.
On 2011/11/09 18:16:25, rsesek wrote:
> nit: copyright

Done.  I stopped paying much attention to those once the commit bot started
doing it for me...

http://codereview.chromium.org/8498034/diff/1/chrome/browser/chrome_browser_a...
chrome/browser/chrome_browser_application_mac.h:19: // Array of objects
implementing the CrApplicationEventHookProtocol
On 2011/11/09 18:16:25, rsesek wrote:
> nit: full stop

Done.

http://codereview.chromium.org/8498034/diff/1/content/common/chrome_applicati...
File content/common/chrome_application_mac.h (right):

http://codereview.chromium.org/8498034/diff/1/content/common/chrome_applicati...
content/common/chrome_application_mac.h:14: #include
"base/memory/scoped_nsobject.h"
On 2011/11/09 18:16:25, rsesek wrote:
> nit: remove

Done.

http://codereview.chromium.org/8498034/diff/1/content/common/chrome_applicati...
content/common/chrome_application_mac.h:15: #import
"content/common/mac/scoped_sending_event.h"
On 2011/11/09 18:16:25, rsesek wrote:
> can move into .mm

Defines the necessary protocol.

[Robert Sesek, 2011-11-09 18:38:59]

lgtm

http://codereview.chromium.org/8498034/diff/1/content/common/chrome_applicati...
File content/common/chrome_application_mac.h (right):

http://codereview.chromium.org/8498034/diff/1/content/common/chrome_applicati...
content/common/chrome_application_mac.h:15: #import
"content/common/mac/scoped_sending_event.h"
On 2011/11/09 18:36:53, shess wrote:
> On 2011/11/09 18:16:25, rsesek wrote:
> > can move into .mm
> 
> Defines the necessary protocol.

Oops, you're right.

http://codereview.chromium.org/8498034/diff/5001/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_application_mac.h (right):

http://codereview.chromium.org/8498034/diff/5001/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_application_mac.h:18: @interface
BrowserCrApplication : CrApplication {
 @private

[Scott Hess - ex-Googler, 2011-11-09 18:48:32]

John, another OWNERS blessing.  Moved some Mac code up from content/ to chrome/,
already reviewed for platform appropriateness.

[There will be one more, but it'll probably involve arguments.]

http://codereview.chromium.org/8498034/diff/5001/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_application_mac.h (right):

http://codereview.chromium.org/8498034/diff/5001/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_application_mac.h:18: @interface
BrowserCrApplication : CrApplication {
On 2011/11/09 18:38:59, rsesek wrote:
>  @private

Done.  If you haven't noticed, I get dinged for this every time.  I think
@private landed during my Objective-C interregnum.

[jam, 2011-11-10 17:38:23]

sweet, thanks for doing this. lgtm

[commit-bot: I haz the power, 2011-11-10 18:16:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/8498034/2006

[commit-bot: I haz the power, 2011-11-10 19:59:28]

Try job failure for 8498034-2006 (retry) (retry) on mac_rel for step
"unit_tests".
It's a second try, previously, step "unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Scott Hess - ex-Googler, 2011-11-10 20:56:43]

On 2011/11/10 19:59:28, I haz the power (commit-bot) wrote:
> Try job failure for 8498034-2006 (retry) (retry) on mac_rel for step
> "unit_tests".
> It's a second try, previously, step "unit_tests" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Ahhhh.  The test creates NSExceptions for checking that exceptions are
histogrammed correctly, which worked when using CrApplication. 
BrowserCrApplication makes NSExceptions fatal, so you can't go there.  Crazy.

Robert, looks like presubmit still passes, so I'm going to just commit-queue
this puppy, and assume a TBR WRT the new
chrome_browser_application_mac_unittest.mm change.

[Robert Sesek, 2011-11-10 20:59:47]

lgtm

http://codereview.chromium.org/8498034/diff/16001/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_application_mac_unittest.mm (right):

http://codereview.chromium.org/8498034/diff/16001/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_application_mac_unittest.mm:8: #import
"base/mac/scoped_nsexception_enabler.h"
nit: alphabetize

[Scott Hess - ex-Googler, 2011-11-10 21:06:51]

http://codereview.chromium.org/8498034/diff/16001/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_application_mac_unittest.mm (right):

http://codereview.chromium.org/8498034/diff/16001/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_application_mac_unittest.mm:8: #import
"base/mac/scoped_nsexception_enabler.h"
On 2011/11/10 20:59:47, rsesek wrote:
> nit: alphabetize

I hate you.

More precisely, I hate my aged eyes and brain, because I actually did explicitly
check to make sure this line was placed alphabetically.

[commit-bot: I haz the power, 2011-11-11 22:03:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/8498034/16001

[commit-bot: I haz the power, 2011-11-12 00:54:12]

Change committed as 109749