Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1666)

Issue 8498032: Switching all wstrings in courgette_tool to FilePaths. (Closed)

Created:
9 years, 1 month ago by dgarrett
Modified:
9 years, 1 month ago
Reviewers:
sra1, evanm
CC:
chromium-reviews, adlr, Michael Krebs
Visibility:
Public.

Description

Switching all wstrings in courgette_tool to FilePaths. Presubmit checks now consider the presence of wstring to be an error, so switching all wstrings in courgette_tool to FilePath's as evanm had already called out in a TODO. BUG=chromiumos:22693 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110611

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove redundant #if. #

Patch Set 3 : Fix cross-platform string insertion??? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -57 lines) Patch
M courgette/courgette_tool.cc View 1 2 10 chunks +35 lines, -57 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dgarrett
I had a small change for courgette_tool, but the presubmit checks now error out if ...
9 years, 1 month ago (2011-11-09 00:43:53 UTC) #1
dgarrett
Ping?
9 years, 1 month ago (2011-11-16 20:25:01 UTC) #2
sra1
lgtm http://codereview.chromium.org/8498032/diff/1/courgette/courgette_tool.cc File courgette/courgette_tool.cc (right): http://codereview.chromium.org/8498032/diff/1/courgette/courgette_tool.cc#newcode411 courgette/courgette_tool.cc:411: values.push_back(FilePath(args[i])); Can remove the #if now. Just test ...
9 years, 1 month ago (2011-11-16 21:04:25 UTC) #3
dgarrett
Fixed your problem, and fixed a small issue building on Windows. I should test with ...
9 years, 1 month ago (2011-11-17 22:44:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgarrett@chromium.org/8498032/8001
9 years, 1 month ago (2011-11-17 22:44:34 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-18 00:21:34 UTC) #6
Change committed as 110611

Powered by Google App Engine
This is Rietveld 408576698