chrome/browser/ui/views/extensions/extension_popup.cc - Issue 8498022: Have ExtensionHost use TabContents instead of RenderViewHost. Try #2. The first

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 8498022: Have ExtensionHost use TabContents instead of RenderViewHost. Try #2. The first (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_popup.h ('k') | chrome/browser/ui/views/extensions/extension_view.h » ('j') | content/browser/tab_contents/tab_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_popup.cc

diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc

index 654db01b58e0e6597338f64cb15775685d10990a..6b73c3981d8e0010ab462768212032302f290bfc 100644

--- a/chrome/browser/ui/views/extensions/extension_popup.cc

+++ b/chrome/browser/ui/views/extensions/extension_popup.cc

@@ -17,6 +17,7 @@

#include "chrome/common/extensions/extension.h"

#include "content/browser/renderer_host/render_view_host.h"

#include "content/browser/renderer_host/render_widget_host_view.h"

+#include "content/browser/tab_contents/tab_contents.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_source.h"

#include "views/widget/root_view.h"

@@ -95,7 +96,7 @@ void ExtensionPopup::BubbleBrowserWindowClosing(BrowserBubble* bubble) {

void ExtensionPopup::BubbleGotFocus(BrowserBubble* bubble) {

// Forward the focus to the renderer.

- host()->render_view_host()->view()->Focus();

+ host()->host_contents()->Focus();

}

void ExtensionPopup::BubbleLostFocus(BrowserBubble* bubble,