chrome/browser/ui/cocoa/extensions/extension_view_mac.h - Issue 8498022: Have ExtensionHost use TabContents instead of RenderViewHost. Try #2. The first

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_view_mac.h

Issue 8498022: Have ExtensionHost use TabContents instead of RenderViewHost. Try #2. The first (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/task_manager_resource_providers.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_view_mac.mm » ('j') | chrome/browser/ui/cocoa/extensions/extension_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_view_mac.h

diff --git a/chrome/browser/ui/cocoa/extensions/extension_view_mac.h b/chrome/browser/ui/cocoa/extensions/extension_view_mac.h

index abcc31ee99cf1f9f3f5d0714f71f672bf85344d8..6668d08f166733249cefe983c43e64f2ff2bdc08 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_view_mac.h

+++ b/chrome/browser/ui/cocoa/extensions/extension_view_mac.h

@@ -14,7 +14,6 @@

class Browser;

class ExtensionHost;

class RenderViewHost;

-class RenderWidgetHostViewMac;

class SkBitmap;

// This class represents extension views. An extension view internally contains

@@ -67,10 +66,6 @@ class ExtensionViewMac {

ExtensionHost* extension_host_; // weak

- // Created by us, but owned by its |native_view()|. We |release| the

- // rwhv's native view in our destructor, effectively freeing this.

- RenderWidgetHostViewMac* render_widget_host_view_;

// The background the view should have once it is initialized. This is set

// when the view has a custom background, but hasn't been initialized yet.

SkBitmap pending_background_;