Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8498007: ContentSettingsObserver (+ related classes) cleanup. (Closed)

Created:
9 years, 1 month ago by marja
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, jochen (gone - plz use gerrit), markusheintz_
Visibility:
Public.

Description

ContentSettingsObserver (+ related classes) cleanup. Per-page content settings and default content settings are no longer needed, since the renderer stores the content setting rules for images and scripts. BUG=102662 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109228

Patch Set 1 #

Patch Set 2 : Removing struct ContentSettings, too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -404 lines) Patch
M chrome/browser/content_settings/content_settings_default_provider.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider.cc View 1 5 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.h View 1 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 2 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 1 4 chunks +59 lines, -86 lines 0 comments Download
M chrome/browser/content_settings/mock_settings_observer.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 2 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/content_settings.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/content_settings.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 chunks +0 lines, -27 lines 0 comments Download
M chrome/common/render_messages.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 4 chunks +0 lines, -45 lines 0 comments Download
M chrome/renderer/content_settings_observer.h View 1 2 chunks +0 lines, -28 lines 0 comments Download
M chrome/renderer/content_settings_observer.cc View 5 chunks +2 lines, -71 lines 0 comments Download
M chrome/renderer/content_settings_observer_browsertest.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
marja
Here's the ContentSettingsObserver cleanup which I said I'll do in a separate CL. Bernhard, could ...
9 years, 1 month ago (2011-11-08 11:00:32 UTC) #1
Bernhard Bauer
LGTM. Thanks!
9 years, 1 month ago (2011-11-08 11:21:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/8498007/1
9 years, 1 month ago (2011-11-08 11:22:42 UTC) #3
Bernhard Bauer
Actually, can you remove the ContentSettings struct completely?
9 years, 1 month ago (2011-11-08 11:25:10 UTC) #4
marja
On 2011/11/08 11:25:10, Bernhard Bauer wrote: > Actually, can you remove the ContentSettings struct completely? ...
9 years, 1 month ago (2011-11-08 16:23:43 UTC) #5
markusheintz_
Cool! Thanks for creating this CL LGTM
9 years, 1 month ago (2011-11-08 17:39:31 UTC) #6
marja
Bernhard, does this still LGTY?
9 years, 1 month ago (2011-11-09 10:04:49 UTC) #7
Bernhard Bauer
On 2011/11/09 10:04:49, marja wrote: > Bernhard, does this still LGTY? Yup, ship it! :)
9 years, 1 month ago (2011-11-09 10:07:21 UTC) #8
markusheintz_
Please add a bug number.
9 years, 1 month ago (2011-11-09 10:07:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/8498007/3002
9 years, 1 month ago (2011-11-09 11:42:59 UTC) #10
commit-bot: I haz the power
9 years, 1 month ago (2011-11-09 12:55:16 UTC) #11 
Change committed as 109228

Powered by Google App Engine
This is Rietveld 408576698