Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Unified Diff: chrome/browser/extensions/settings/settings_frontend.h

Issue 8497065: Extension Settings API: make it so that when leveldb storage areas fail to be (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings/settings_frontend.h
diff --git a/chrome/browser/extensions/settings/settings_frontend.h b/chrome/browser/extensions/settings/settings_frontend.h
index 93b24d049f469077ddbfd5d89d2e2c92c8105854..ed4e12bda27a6c78a33f5f607114c8e8894ab2a6 100644
--- a/chrome/browser/extensions/settings/settings_frontend.h
+++ b/chrome/browser/extensions/settings/settings_frontend.h
@@ -11,6 +11,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/observer_list_threadsafe.h"
+#include "chrome/browser/extensions/settings/settings_leveldb_storage.h"
#include "chrome/browser/extensions/settings/settings_observer.h"
#include "chrome/browser/sync/api/syncable_service.h"
#include "content/public/browser/notification_observer.h"
@@ -28,7 +29,15 @@ class SettingsStorage;
// All public methods must be called on the UI thread.
class SettingsFrontend {
public:
- explicit SettingsFrontend(Profile* profile);
+ // Creates with the default factory. Ownership of |profile| not taken.
+ static SettingsFrontend* Create(Profile* profile);
+
+ static SettingsFrontend* Create(
+ // Ownership taken.
+ SettingsStorageFactory* storage_factory,
+ // Owership NOT taken.
+ Profile* profile);
+
virtual ~SettingsFrontend();
typedef base::Callback<void(SyncableService*)> SyncableServiceCallback;
@@ -68,6 +77,12 @@ class SettingsFrontend {
Profile* const profile_;
};
+ SettingsFrontend(
+ // Ownership taken.
+ SettingsStorageFactory* storage_factory,
+ // Ownership NOT taken.
+ Profile* profile);
+
// The (non-incognito) Profile this Frontend belongs to.
Profile* const profile_;
« no previous file with comments | « chrome/browser/extensions/settings/settings_backend.cc ('k') | chrome/browser/extensions/settings/settings_frontend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698